[telemetry] Fix CPU metric jiffie overflow correction.

[telemetry] Fix CPU metric jiffie overflow correction.

The jiffie counter is at 100 Hz, so the correction should be divided by 100.

BUG=671635
Committed: https://crrev.com/8617703b123bda515544f1a68803e4911bf947d3
Cr-Commit-Position: refs/heads/master@{#438248}

[dtu, 2016-12-06 19:47:13]

dtu@chromium.org changed reviewers:
+ skyostil@chromium.org

[mikecase (-- gone --), 2016-12-06 19:54:14]

mikecase@chromium.org changed reviewers:
+ mikecase@chromium.org

[mikecase (-- gone --), 2016-12-06 19:54:15]

https://codereview.chromium.org/2560543002/diff/1/tools/perf/metrics/cpu.py
File tools/perf/metrics/cpu.py (right):

https://codereview.chromium.org/2560543002/diff/1/tools/perf/metrics/cpu.py#n...
tools/perf/metrics/cpu.py:92: total_time += 2 ** 32 / 100.
do you need to divide by 100 if total_time > 0?

[dtu, 2016-12-06 20:33:58]

https://codereview.chromium.org/2560543002/diff/1/tools/perf/metrics/cpu.py
File tools/perf/metrics/cpu.py (right):

https://codereview.chromium.org/2560543002/diff/1/tools/perf/metrics/cpu.py#n...
tools/perf/metrics/cpu.py:92: total_time += 2 ** 32 / 100.
On 2016/12/06 19:54:15, mikecase wrote:
> do you need to divide by 100 if total_time > 0?

No, the log shows that the values in cpu_stats were already divided by 100. So
we just need to divide this correction factor to match the same units.


Locals:
  cpu_process_time : 0.23000000000000004
  cpu_stats        : {'Gpu': {'TotalTime': 5.46, 'CpuProcessTime': 0.68},
'Other': {}, 'Renderer': {'TotalTime': 5.46, 'CpuProcessTime': 0.91}, 'Browser':
{'TotalTime': 5.46, 'CpuProcessTime': 2.51}}
  cpu_usage        : {}
  process_type     : 'Gpu'
  start_cpu_stats  : {'Gpu': {'TotalTime': 42949670.36, 'CpuProcessTime': 0.45},
'Other': {}, 'Renderer': {'TotalTime': 42949670.36, 'CpuProcessTime': 0.63},
'Browser': {'TotalTime': 42949670.36, 'CpuProcessTime': 2.24}}
  total_time       : 4252017631.1

[Sami, 2016-12-07 17:20:12]

lgtm.

https://codereview.chromium.org/2560543002/diff/1/tools/perf/metrics/cpu.py
File tools/perf/metrics/cpu.py (right):

https://codereview.chromium.org/2560543002/diff/1/tools/perf/metrics/cpu.py#n...
tools/perf/metrics/cpu.py:94: assert total_time > 0 and total_time < 2 ** 31, (
Should this upper limit be fixed too?

[dtu, 2016-12-08 00:55:29]

https://codereview.chromium.org/2560543002/diff/1/tools/perf/metrics/cpu.py
File tools/perf/metrics/cpu.py (right):

https://codereview.chromium.org/2560543002/diff/1/tools/perf/metrics/cpu.py#n...
tools/perf/metrics/cpu.py:94: assert total_time > 0 and total_time < 2 ** 31, (
On 2016/12/07 17:20:12, Sami wrote:
> Should this upper limit be fixed too?

Done.

[dtu, 2016-12-08 00:55:31]

The CQ bit was checked by dtu@chromium.org

[dtu, 2016-12-08 00:55:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2560543002/#ps20001
(title: "Update assertion")

[commit-bot: I haz the power, 2016-12-08 00:55:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 01:42:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 01:42:56]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dtu, 2016-12-08 04:00:38]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2016-12-08 04:00:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 04:47:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 04:47:14]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dtu, 2016-12-09 19:38:13]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2016-12-09 19:39:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 20:51:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 20:51:09]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dtu, 2016-12-10 01:43:18]

The CQ bit was checked by dtu@chromium.org

[dtu, 2016-12-10 01:43:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2560543002/#ps40001
(title: "Update unit test.")

[commit-bot: I haz the power, 2016-12-10 01:44:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 02:53:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 02:53:29]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dtu, 2016-12-12 21:52:44]

The CQ bit was checked by dtu@chromium.org

[dtu, 2016-12-12 21:52:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2560543002/#ps60001
(title: "Typo.")

[commit-bot: I haz the power, 2016-12-12 21:54:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 01:05:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 01:05:14]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dtu, 2016-12-13 18:12:30]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2016-12-13 18:12:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 19:23:26]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481652750626350,
"parent_rev": "ec83b4f0fe6bd4314068ce8f44b637c83c33d668", "commit_rev":
"55ec9e576aac7339aa7cbe99c2d2f3a641f3bce7"}

[commit-bot: I haz the power, 2016-12-13 19:23:52]

Description was changed from

==========
[telemetry] Fix CPU metric jiffie overflow correction.

The jiffie counter is at 100 Hz, so the correction should be divided by 100.

BUG=671635
==========

to

==========
[telemetry] Fix CPU metric jiffie overflow correction.

The jiffie counter is at 100 Hz, so the correction should be divided by 100.

BUG=671635

Review-Url: https://codereview.chromium.org/2560543002
==========

[commit-bot: I haz the power, 2016-12-13 19:23:53]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-13 19:26:25]

Description was changed from

==========
[telemetry] Fix CPU metric jiffie overflow correction.

The jiffie counter is at 100 Hz, so the correction should be divided by 100.

BUG=671635

Review-Url: https://codereview.chromium.org/2560543002
==========

to

==========
[telemetry] Fix CPU metric jiffie overflow correction.

The jiffie counter is at 100 Hz, so the correction should be divided by 100.

BUG=671635

Committed: https://crrev.com/8617703b123bda515544f1a68803e4911bf947d3
Cr-Commit-Position: refs/heads/master@{#438248}
==========

[commit-bot: I haz the power, 2016-12-13 19:26:26]

Patchset 4 (id:??) landed as
https://crrev.com/8617703b123bda515544f1a68803e4911bf947d3
Cr-Commit-Position: refs/heads/master@{#438248}