Issue 256043004: Merge 172281 "[DevTools] Minor tweak in popover positioning."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 256043004: Merge 172281 "[DevTools] Minor tweak in popover positioning." (Closed)

Created:
6 years, 7 months ago by dgozman

Modified:
6 years, 7 months ago

Reviewers:
dgozman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/branches/chromium/1916/

Visibility:
Public.

More Reviews

Description

Merge 172281 "[DevTools] Minor tweak in popover positioning." > [DevTools] Minor tweak in popover positioning. > > When positioning popover below anchor, the visible bottom coordinate was wrong: |arrowHeight - borderWidth| instead of |borderRadius|. > Consequently, it caused wrong position update, and popover did extend below container element, which is unacceptable and leads to bad layout. > > BUG=363535 > > Review URL: https://codereview.chromium.org/246823003 TBR=dgozman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172736

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/devtools/front_end/Popover.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r172736.

Expand Messages | Collapse Messages