Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 246823003: [DevTools] Minor tweak in popover positioning. (Closed)

Created:
6 years, 8 months ago by dgozman
Modified:
6 years, 8 months ago
Reviewers:
apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[DevTools] Minor tweak in popover positioning. When positioning popover below anchor, the visible bottom coordinate was wrong: |arrowHeight - borderWidth| instead of |borderRadius|. Consequently, it caused wrong position update, and popover did extend below container element, which is unacceptable and leads to bad layout. BUG=363535 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172281

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/devtools/front_end/Popover.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
dgozman
Could you please take a look?
6 years, 8 months ago (2014-04-22 16:08:38 UTC) #1
apavlov
lgtm
6 years, 8 months ago (2014-04-22 16:18:03 UTC) #2
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 8 months ago (2014-04-22 16:18:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/246823003/1
6 years, 8 months ago (2014-04-22 16:18:57 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-22 17:26:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-22 17:26:57 UTC) #6
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 8 months ago (2014-04-22 17:33:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/246823003/1
6 years, 8 months ago (2014-04-22 17:33:55 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-22 18:39:59 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-22 18:40:00 UTC) #10
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 8 months ago (2014-04-22 19:48:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/246823003/1
6 years, 8 months ago (2014-04-22 19:48:42 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 23:35:37 UTC) #13
Message was sent while issue was closed.
Change committed as 172281

Powered by Google App Engine
This is Rietveld 408576698