Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2560423003: Remove [ Win ] from RandomOrderExpectations (Closed)

Created:
4 years ago by jeffcarp
Modified:
4 years ago
Reviewers:
qyearsley
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove [ Win ] from RandomOrderExpectations It doesn't seem like it's being respected. See build: https://build.chromium.org/p/chromium.fyi/builders/WebKit%20Win%20-%20RandomOrder/builds/382 It's getting close to Wednesday - I'd like to remove [ Win ] so we can get onto more important work and then circle back around when we have more time to find the correct prefix. R=qyearsley@chromium.org BUG=670843 Committed: https://crrev.com/41dbdcc8a8f30b9ca4e7869b72a2154ebe64553e Cr-Commit-Position: refs/heads/master@{#437986}

Patch Set 1 #

Patch Set 2 : Remove all [ Win ] prefixes, they seem like they're not being respected #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/RandomOrderExpectations View 1 5 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
jeffcarp
4 years ago (2016-12-12 03:10:07 UTC) #1
jeffcarp
On 2016/12/12 at 03:10:07, jeffcarp wrote: > Maybe I spoke too soon, it looks like ...
4 years ago (2016-12-12 15:27:49 UTC) #2
jeffcarp
On 2016/12/12 at 15:27:49, jeffcarp wrote: > On 2016/12/12 at 03:10:07, jeffcarp wrote: > > ...
4 years ago (2016-12-12 20:24:03 UTC) #4
qyearsley
lgtm
4 years ago (2016-12-13 00:52:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560423003/20001
4 years ago (2016-12-13 00:53:26 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 02:09:10 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-13 02:12:48 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/41dbdcc8a8f30b9ca4e7869b72a2154ebe64553e
Cr-Commit-Position: refs/heads/master@{#437986}

Powered by Google App Engine
This is Rietveld 408576698