Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2560353002: DevTools: move the GC button into the memory panel. (Closed)

Created:
4 years ago by pfeldman
Modified:
4 years ago
Reviewers:
caseq, alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: move the GC button into the memory panel. Committed: https://crrev.com/741d84a559778c826ca9ae62203a6cae05e7eb79 Cr-Commit-Position: refs/heads/master@{#437736}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -15 lines) Patch
M third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js View 2 chunks +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/module.json View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js View 3 chunks +2 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
pfeldman
4 years ago (2016-12-10 00:23:55 UTC) #2
caseq
lgtm
4 years ago (2016-12-10 00:26:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560353002/1
4 years ago (2016-12-10 00:27:21 UTC) #5
alph
I remember there was a use case when you record counters (DOM nodes, event listeners) ...
4 years ago (2016-12-10 00:28:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-10 03:30:40 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-12 15:05:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/741d84a559778c826ca9ae62203a6cae05e7eb79
Cr-Commit-Position: refs/heads/master@{#437736}

Powered by Google App Engine
This is Rietveld 408576698