Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2560173002:
Add new experiment code for TunedClippingLevelMin (Closed)
|
Created:
4 years ago by hlundin-chromium Modified:
4 years ago CC:
chromium-reviews, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, jasonroberts+watch_google.com, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org, sdoyon Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd new experiment code for TunedClippingLevelMin
This CL wires up the experiment settings for tuning WebRTC's gain
control. Four different new values are provided as feature flags (to
be controlled by a Finch experiment or directly from command line
flags).
BUG=chromium:672476, webrtc:6622
Committed: https://crrev.com/69bddded7f0b0ce7a126f065201dc57fda4f21c5
Cr-Commit-Position: refs/heads/master@{#437847}
Patch Set 1 #Patch Set 2 : Add feature for the control group (170) too #Patch Set 3 : Rebase #Messages
Total messages: 19 (9 generated)
Description was changed from ========== Add new experiment code for TunedClippingLevelMin This CL wires up the experiment settings for tuning WebRTC's gain control. Four different new values are provided as feature flags (to be controlled by a Finch experiment or directly from command line flags). BUG=chromium:672476,webrtc:6622 ========== to ========== Add new experiment code for TunedClippingLevelMin This CL wires up the experiment settings for tuning WebRTC's gain control. Four different new values are provided as feature flags (to be controlled by a Finch experiment or directly from command line flags). BUG=chromium:672476,webrtc:6622 ==========
hlundin@chromium.org changed reviewers: + peah@chromium.org, tommi@chromium.org
peah, tommi, Please, take a look. Thanks!
lgtm
You will also need a feature for the value you want to use as your control, unfortunately. (IIUC that's 170?) I will explain further in the Finch config CL review. -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Rebase
The CQ bit was checked by hlundin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org Link to the patchset: https://codereview.chromium.org/2560173002/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by hlundin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Great! lgtm!
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481535581944530,
"parent_rev": "fd95e8b07a10077156275858cf47373a93db814d", "commit_rev":
"072884302060c092b32bdecdebd979d5703fe504"}
Message was sent while issue was closed.
Description was changed from ========== Add new experiment code for TunedClippingLevelMin This CL wires up the experiment settings for tuning WebRTC's gain control. Four different new values are provided as feature flags (to be controlled by a Finch experiment or directly from command line flags). BUG=chromium:672476,webrtc:6622 ========== to ========== Add new experiment code for TunedClippingLevelMin This CL wires up the experiment settings for tuning WebRTC's gain control. Four different new values are provided as feature flags (to be controlled by a Finch experiment or directly from command line flags). BUG=chromium:672476,webrtc:6622 Review-Url: https://codereview.chromium.org/2560173002 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Add new experiment code for TunedClippingLevelMin This CL wires up the experiment settings for tuning WebRTC's gain control. Four different new values are provided as feature flags (to be controlled by a Finch experiment or directly from command line flags). BUG=chromium:672476,webrtc:6622 Review-Url: https://codereview.chromium.org/2560173002 ========== to ========== Add new experiment code for TunedClippingLevelMin This CL wires up the experiment settings for tuning WebRTC's gain control. Four different new values are provided as feature flags (to be controlled by a Finch experiment or directly from command line flags). BUG=chromium:672476,webrtc:6622 Committed: https://crrev.com/69bddded7f0b0ce7a126f065201dc57fda4f21c5 Cr-Commit-Position: refs/heads/master@{#437847} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/69bddded7f0b0ce7a126f065201dc57fda4f21c5 Cr-Commit-Position: refs/heads/master@{#437847} |
