chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc - Issue 2560043004: [PageLoadMetrics] Record bytes usage per page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

Issue 2560043004: [PageLoadMetrics] Record bytes usage per page (Closed)

Patch Set: Fix test Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/page_load_metrics_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

index bbd1bbe8a57bd7c260d74565ed6c8a24f21e7a60..47f3cd759f94236371738838fce85bcdbb6c770c 100644

--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

@@ -482,6 +482,14 @@ TEST_F(CorePageLoadMetricsObserverTest, NewNavigation) {

timing.parse_start.value().InMilliseconds(), 1);

}

+TEST_F(CorePageLoadMetricsObserverTest, BytesCounted) {

+ NavigateAndCommit(GURL(kDefaultTestUrl));

+ NavigateAndCommit(GURL(kDefaultTestUrl2));

+ histogram_tester().ExpectTotalCount(internal::kHistogramTotalBytes, 1);

+ histogram_tester().ExpectTotalCount(internal::kHistogramNetworkBytes, 1);

+ histogram_tester().ExpectTotalCount(internal::kHistogramCacheBytes, 1);

TEST_F(CorePageLoadMetricsObserverTest, FirstMeaningfulPaint) {

page_load_metrics::PageLoadTiming timing;

timing.navigation_start = base::Time::FromDoubleT(1);