Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

Issue 2560043004: [PageLoadMetrics] Record bytes usage per page (Closed)
Patch Set: Fix test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
index 6d6e2b549f8819d2417dd310a9ac38e3f745634c..f137a0da5299ca6ce9678af9f68787add99a9e2f 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
@@ -203,6 +203,10 @@ const char kHistogramFirstNonScrollInputAfterFirstPaint[] =
const char kHistogramFirstScrollInputAfterFirstPaint[] =
"PageLoad.InputTiming.NavigationToFirstScroll.AfterPaint";
+const char kHistogramTotalBytes[] = "PageLoad.Experimental.Bytes.Total";
+const char kHistogramNetworkBytes[] = "PageLoad.Experimental.Bytes.Network";
+const char kHistogramCacheBytes[] = "PageLoad.Experimental.Bytes.Cache";
+
} // namespace internal
CorePageLoadMetricsObserver::CorePageLoadMetricsObserver()
@@ -532,6 +536,20 @@ void CorePageLoadMetricsObserver::OnComplete(
const page_load_metrics::PageLoadExtraInfo& info) {
RecordTimingHistograms(timing, info);
RecordRappor(timing, info);
+
+ int64_t total_kb = (info.network_bytes + info.cache_bytes) / 1024;
+ int64_t network_kb = info.network_bytes / 1024;
+ int64_t cache_kb = info.cache_bytes / 1024;
+ DCHECK_LE(network_kb, total_kb);
+ DCHECK_LE(cache_kb, total_kb);
+ DCHECK_LE(total_kb, std::numeric_limits<int>::max());
+
+ UMA_HISTOGRAM_CUSTOM_COUNTS(internal::kHistogramNetworkBytes,
+ static_cast<int>(network_kb), 1, 500 * 1024, 50);
+ UMA_HISTOGRAM_CUSTOM_COUNTS(internal::kHistogramCacheBytes,
+ static_cast<int>(cache_kb), 1, 500 * 1024, 50);
+ UMA_HISTOGRAM_CUSTOM_COUNTS(internal::kHistogramTotalBytes,
+ static_cast<int>(total_kb), 1, 500 * 1024, 50);
}
void CorePageLoadMetricsObserver::OnFailedProvisionalLoad(

Powered by Google App Engine
This is Rietveld 408576698