Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: chrome/android/java/res/layout/main.xml

Issue 2560043002: ControlContainer is now a child of CompositorViewHolder (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/main.xml
diff --git a/chrome/android/java/res/layout/main.xml b/chrome/android/java/res/layout/main.xml
index ab98289b346b663b96268da0fe8632b27a2c8767..8bc84df26ed2da4f353d4514eb37e4d48d2ee5c3 100644
--- a/chrome/android/java/res/layout/main.xml
+++ b/chrome/android/java/res/layout/main.xml
@@ -3,8 +3,7 @@
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file. -->
-<merge xmlns:android="http://schemas.android.com/apk/res/android"
- xmlns:app="http://schemas.android.com/apk/res-auto" >
+<merge xmlns:android="http://schemas.android.com/apk/res/android">
<LinearLayout
android:layout_width="match_parent"
android:layout_height="match_parent"
@@ -35,6 +34,24 @@
android:layout_height="match_parent"
android:layout_gravity="start|bottom" />
+ <!-- Toolbar size area painted black to avoid the action bar showing the window background -->
+ <View
+ android:id="@+id/action_bar_black_background"
+ android:layout_width="match_parent"
+ android:layout_height="@dimen/toolbar_height_no_shadow"
+ android:background="@android:color/black"
+ android:visibility="gone" />
gone 2017/01/13 18:31:08 follow file convention and put newlines between th
mdjones 2017/01/13 19:56:41 Done.
+ <ViewStub
+ android:id="@+id/control_container_stub"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content" />
+ <ViewStub
+ android:id="@+id/empty_container_stub"
+ android:inflatedId="@+id/empty_container"
+ android:layout="@layout/empty_background_view_tablet"
+ android:layout_width="match_parent"
+ android:layout_height="match_parent" />
+
</android.support.design.widget.CoordinatorLayout>
<HorizontalScrollView
@@ -54,23 +71,6 @@
android:layout_height="wrap_content" />
</LinearLayout>
- <!-- Toolbar size area painted black to avoid the action bar showing the window background -->
- <View
- android:id="@+id/action_bar_black_background"
- android:layout_width="match_parent"
- android:layout_height="@dimen/toolbar_height_no_shadow"
- android:background="#000000"
- android:visibility="gone" />
- <ViewStub
- android:id="@+id/control_container_stub"
- android:layout_width="match_parent"
- android:layout_height="wrap_content" />
- <ViewStub
- android:id="@+id/empty_container_stub"
- android:inflatedId="@+id/empty_container"
- android:layout="@layout/empty_background_view_tablet"
- android:layout_width="match_parent"
- android:layout_height="match_parent" />
<!-- This empty view is used as the anchor for custom menu -->
<View
android:id="@+id/menu_anchor_stub"

Powered by Google App Engine
This is Rietveld 408576698