Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: chrome/android/java/res/layout/main.xml

Issue 2560043002: ControlContainer is now a child of CompositorViewHolder (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <merge xmlns:android="http://schemas.android.com/apk/res/android" 6 <merge xmlns:android="http://schemas.android.com/apk/res/android">
7 xmlns:app="http://schemas.android.com/apk/res-auto" >
8 <LinearLayout 7 <LinearLayout
9 android:layout_width="match_parent" 8 android:layout_width="match_parent"
10 android:layout_height="match_parent" 9 android:layout_height="match_parent"
11 android:orientation="vertical"> 10 android:orientation="vertical">
12 11
13 <android.support.design.widget.CoordinatorLayout 12 <android.support.design.widget.CoordinatorLayout
14 android:id="@+id/coordinator" 13 android:id="@+id/coordinator"
15 android:layout_width="match_parent" 14 android:layout_width="match_parent"
16 android:layout_height="0dp" 15 android:layout_height="0dp"
17 android:layout_weight="1" > 16 android:layout_weight="1" >
(...skipping 10 matching lines...) Expand all
28 android:layout_marginTop="@dimen/tab_strip_height" 27 android:layout_marginTop="@dimen/tab_strip_height"
29 android:inflatedId="@+id/omnibox_results_container" 28 android:inflatedId="@+id/omnibox_results_container"
30 android:layout="@layout/omnibox_results_container" /> 29 android:layout="@layout/omnibox_results_container" />
31 30
32 <FrameLayout 31 <FrameLayout
33 android:id="@+id/bottom_container" 32 android:id="@+id/bottom_container"
34 android:layout_width="match_parent" 33 android:layout_width="match_parent"
35 android:layout_height="match_parent" 34 android:layout_height="match_parent"
36 android:layout_gravity="start|bottom" /> 35 android:layout_gravity="start|bottom" />
37 36
37 <!-- Toolbar size area painted black to avoid the action bar showing the window background -->
38 <View
39 android:id="@+id/action_bar_black_background"
40 android:layout_width="match_parent"
41 android:layout_height="@dimen/toolbar_height_no_shadow"
42 android:background="@android:color/black"
43 android:visibility="gone" />
gone 2017/01/13 18:31:08 follow file convention and put newlines between th
mdjones 2017/01/13 19:56:41 Done.
44 <ViewStub
45 android:id="@+id/control_container_stub"
46 android:layout_width="match_parent"
47 android:layout_height="wrap_content" />
48 <ViewStub
49 android:id="@+id/empty_container_stub"
50 android:inflatedId="@+id/empty_container"
51 android:layout="@layout/empty_background_view_tablet"
52 android:layout_width="match_parent"
53 android:layout_height="match_parent" />
54
38 </android.support.design.widget.CoordinatorLayout> 55 </android.support.design.widget.CoordinatorLayout>
39 56
40 <HorizontalScrollView 57 <HorizontalScrollView
41 android:id="@+id/keyboard_accessory" 58 android:id="@+id/keyboard_accessory"
42 android:layout_height="@dimen/keyboard_accessory_height" 59 android:layout_height="@dimen/keyboard_accessory_height"
43 android:layout_width="match_parent" 60 android:layout_width="match_parent"
44 android:background="@drawable/keyboard_accessory_background" 61 android:background="@drawable/keyboard_accessory_background"
45 android:contentDescription="@string/autofill_keyboard_accessory_cont ent_description" 62 android:contentDescription="@string/autofill_keyboard_accessory_cont ent_description"
46 android:fillViewport="true" 63 android:fillViewport="true"
47 android:scrollbars="none" 64 android:scrollbars="none"
48 android:visibility="gone" /> 65 android:visibility="gone" />
49 66
50 <ViewStub 67 <ViewStub
51 android:id="@+id/bottombar_stub" 68 android:id="@+id/bottombar_stub"
52 android:layout_width="match_parent" 69 android:layout_width="match_parent"
53 android:layout_marginTop="-4dp" 70 android:layout_marginTop="-4dp"
54 android:layout_height="wrap_content" /> 71 android:layout_height="wrap_content" />
55 </LinearLayout> 72 </LinearLayout>
56 73
57 <!-- Toolbar size area painted black to avoid the action bar showing the win dow background -->
58 <View
59 android:id="@+id/action_bar_black_background"
60 android:layout_width="match_parent"
61 android:layout_height="@dimen/toolbar_height_no_shadow"
62 android:background="#000000"
63 android:visibility="gone" />
64 <ViewStub
65 android:id="@+id/control_container_stub"
66 android:layout_width="match_parent"
67 android:layout_height="wrap_content" />
68 <ViewStub
69 android:id="@+id/empty_container_stub"
70 android:inflatedId="@+id/empty_container"
71 android:layout="@layout/empty_background_view_tablet"
72 android:layout_width="match_parent"
73 android:layout_height="match_parent" />
74 <!-- This empty view is used as the anchor for custom menu --> 74 <!-- This empty view is used as the anchor for custom menu -->
75 <View 75 <View
76 android:id="@+id/menu_anchor_stub" 76 android:id="@+id/menu_anchor_stub"
77 android:layout_width="0px" 77 android:layout_width="0px"
78 android:layout_height="0px" 78 android:layout_height="0px"
79 android:layout_gravity="bottom|start" 79 android:layout_gravity="bottom|start"
80 /> 80 />
81 </merge> 81 </merge>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698