Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2560033002: [url] Reserve space for "scheme://host/" for SchemeHostPort serialization (Closed)

Created:
4 years ago by Charlie Harrison
Modified:
4 years ago
Reviewers:
Mike West
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[url] Reserve space for "scheme://host/" for SchemeHostPort serialization BUG=348655 Committed: https://crrev.com/8b5c37023d617a7b46a27b20c33435d2a494ad33 Cr-Commit-Position: refs/heads/master@{#437523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M url/scheme_host_port.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Charlie Harrison
Mike, PTAL at this trivial CL?
4 years ago (2016-12-08 22:47:56 UTC) #6
Mike West
LGTM.
4 years ago (2016-12-09 12:47:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560033002/1
4 years ago (2016-12-09 12:52:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 12:56:11 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-09 12:58:29 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b5c37023d617a7b46a27b20c33435d2a494ad33
Cr-Commit-Position: refs/heads/master@{#437523}

Powered by Google App Engine
This is Rietveld 408576698