components/password_manager/core/browser/password_manager.cc - Issue 256003003: Enable Automatic Passwords Saving

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 256003003: Enable Automatic Passwords Saving (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/core/browser/password_manager.cc

diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc

index 1ab931f4684effabaff119fa0b6362237492a0c5..8a156921af4a23d675e2eb7a7c2b1342f82c34f2 100644

--- a/components/password_manager/core/browser/password_manager.cc

+++ b/components/password_manager/core/browser/password_manager.cc

@@ -270,7 +270,8 @@ void PasswordManager::OnPasswordFormsParsed(

}

bool PasswordManager::ShouldPromptUserToSavePassword() const {

- return provisional_save_manager_->IsNewLogin() &&

+ return !client_->IsAutomaticPasswordSavingEnabled() &&

+ provisional_save_manager_->IsNewLogin() &&

!provisional_save_manager_->HasGeneratedPassword() &&

!provisional_save_manager_->IsPendingCredentialsPublicSuffixMatch();

}