Enable Automatic Passwords Saving

chrome/browser/password_manager/password_manager_browsertest.cc

Index: chrome/browser/password_manager/password_manager_browsertest.cc
diff --git a/chrome/browser/password_manager/password_manager_browsertest.cc b/chrome/browser/password_manager/password_manager_browsertest.cc
index 79aacd5ba1bcdec70db6b217f5e0dfb8e2906ad9..73e89f6d2c43008d6da4386f0c3246ad8ad44e47 100644
--- a/chrome/browser/password_manager/password_manager_browsertest.cc
+++ b/chrome/browser/password_manager/password_manager_browsertest.cc
@@ -21,6 +21,7 @@
 #include "components/infobars/core/infobar.h"
 #include "components/infobars/core/infobar_manager.h"
 #include "components/password_manager/core/browser/test_password_store.h"
+#include "components/password_manager/core/common/password_manager_switches.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_observer.h"
@@ -162,6 +163,8 @@ class PasswordManagerBrowserTest : public InProcessBrowserTest {
     if (!embedded_test_server()->Started())
       ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
 
+    ASSERT_FALSE(CommandLine::ForCurrentProcess()->HasSwitch(
+        password_manager::switches::kEnableAutomaticPasswordSaving));
     NavigationObserver observer(WebContents());
     GURL url = embedded_test_server()->GetURL(path);
     ui_test_utils::NavigateToURL(browser(), url);
@@ -647,3 +650,44 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
   observer.Wait();
   EXPECT_FALSE(observer.infobar_shown());
 }
+
+IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
+                       PromptWhenEnableAutomaticPasswordSavingSwitchIsNotSet) {
+  NavigateToFile("/password/password_form.html");
+
+  // Fill a form and submit through a <input type="submit"> button.
+  NavigationObserver observer(WebContents());
+  std::string fill_and_submit =
+      "document.getElementById('username_field').value = 'temp';"
+      "document.getElementById('password_field').value = 'random';"
+      "document.getElementById('input_submit_button').click()";
+  ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), fill_and_submit));
+  observer.Wait();
+  EXPECT_TRUE(observer.infobar_shown());
+}
+
+IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
+                       DontPromptWhenEnableAutomaticPasswordSavingSwitchIsSet) {
+  password_manager::TestPasswordStore* password_store =
+      (password_manager::TestPasswordStore*)PasswordStoreFactory::GetForProfile(

[vabr (Chromium), 2014/04/29 13:04:44]

Please don't use C-style casts. Use static_cast<> instead.

Also, please correct the formatting of this line.

[rchtara, 2014/04/29 13:51:24]

Done.

+          browser()->profile(), Profile::IMPLICIT_ACCESS).get();
+
+  ASSERT_TRUE(password_store->stored_passwords().size() == 0);

[vabr (Chromium), 2014/04/29 13:04:44]

Please use
EXPECT_EQ(0u, password_store->stored_passwords().size());
instead. Reasons:
1) EXPECT instead of ASSERT, because the test is still valuable to run after
this fails (it checks for the infobar not shown), and ASSERT would just kill it.
2) _EQ instead of _TRUE, because _EQ prints out the size on error, whereas _TRUE
would just say that the expected and actual values were unequal.

Please also correct this at the end of the test.

[rchtara, 2014/04/29 13:51:24]

Done.

+
+  NavigateToFile("/password/password_form.html");
+
+  // Enable the enable-automatic-password-saving switch
+  CommandLine::ForCurrentProcess()->AppendSwitch(
+      password_manager::switches::kEnableAutomaticPasswordSaving);
+
+  // Fill a form and submit through a <input type="submit"> button.
+  NavigationObserver observer(WebContents());
+  std::string fill_and_submit =
+      "document.getElementById('username_field').value = 'temp';"
+      "document.getElementById('password_field').value = 'random';"
+      "document.getElementById('input_submit_button').click()";
+  ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), fill_and_submit));
+  observer.Wait();
+  EXPECT_FALSE(observer.infobar_shown());
+  ASSERT_TRUE(password_store->stored_passwords().size() == 1);
+}