Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2560023002: [Merge to M56] Prevent the pre-session-restore log spam (Closed)

Created:
4 years ago by afakhry
Modified:
4 years ago
Reviewers:
Marc Treib, xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, melevin+watch_chromium.org, samarth+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, achuith+watch_chromium.org, jfweitz+watch_chromium.org, David Black, Jered, oshima+watch_chromium.org, kmadhusu+watch_chromium.org, skanuj+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[Merge to M56] Prevent the pre-session-restore log spam Avoid using merge_session_throttling_utils::ShouldDelayRequestForProfile() which spams the logs with warnings and changes the state of the profile, and instead use the newly added function in this CL to show the local NTP if the session restore is still pending. TBR=xiyuan@chromium.org,treib@chromium.org BUG=641191 Review-Url: https://codereview.chromium.org/2537263002 Cr-Commit-Position: refs/heads/master@{#437013} (cherry picked from commit 50ade576fb3292ed44ba4d8e3e1d1a999840da82) Committed: https://chromium.googlesource.com/chromium/src/+/08948799b9c4a497563bd2ed2afb58ab8ce880db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M chrome/browser/chromeos/login/signin/merge_session_throttling_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/signin/merge_session_throttling_utils.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/browser/search/search.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
afakhry
4 years ago (2016-12-08 18:28:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
08948799b9c4a497563bd2ed2afb58ab8ce880db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698