Prevent the pre-session-restore log spam

Prevent the pre-session-restore log spam

Avoid using merge_session_throttling_utils::ShouldDelayRequestForProfile() which
spams the logs with warnings and changes the state of the profile, and instead use
the newly added function in this CL to show the local NTP if the session restore
is still pending.

BUG=641191
Committed: https://crrev.com/50ade576fb3292ed44ba4d8e3e1d1a999840da82
Cr-Commit-Position: refs/heads/master@{#437013}

[afakhry, 2016-11-29 21:22:18]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 21:23:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[afakhry, 2016-11-30 01:04:31]

Description was changed from

==========
Prevent the pre-session-restore log spam

BUG=641191
==========

to

==========
Prevent the pre-session-restore log spam

Avoid using merge_session_throttling_utils::ShouldDelayRequestForProfile() which
spams the logs with warnings and changes the state of the profile, and instead
use
the newly added functions in this CL to show the local NTP if the user profile
hasn't
been finalized yet or session restore is still pending.

BUG=641191
==========

[commit-bot: I haz the power, 2016-11-30 01:10:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 01:10:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[afakhry, 2016-11-30 01:16:49]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[afakhry, 2016-11-30 01:17:06]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-11-30 01:17:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[afakhry, 2016-11-30 01:24:32]

afakhry@chromium.org changed reviewers:
+ xiyuan@chromium.org

[afakhry, 2016-11-30 01:24:32]

Xiyuan, please take a look. Thanks!

[commit-bot: I haz the power, 2016-11-30 03:19:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 03:19:48]

Dry run: Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[xiyuan, 2016-11-30 17:32:39]

lgtm

Thanks

[afakhry, 2016-11-30 17:40:42]

afakhry@chromium.org changed reviewers:
+ sky@chromium.org

[afakhry, 2016-11-30 17:40:43]

+sky for search.cc. Thanks!

[sky, 2016-11-30 21:27:51]

sky@chromium.org changed reviewers:
+ treib@chromium.org
- sky@chromium.org

[sky, 2016-11-30 21:27:52]

Please prefer a local owner here. Randomly swapping myself with
treib@chromium.org.

[Marc Treib, 2016-12-01 13:08:02]

c/b/search LGTM

[afakhry, 2016-12-01 16:49:11]

The CQ bit was checked by afakhry@chromium.org

[commit-bot: I haz the power, 2016-12-01 16:49:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 19:00:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 19:00:36]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[afakhry, 2016-12-02 18:08:42]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 18:09:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 19:10:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 19:10:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[afakhry, 2016-12-06 02:56:55]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 02:57:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 03:37:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 03:37:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[afakhry, 2016-12-07 01:36:58]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 01:37:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 02:51:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 02:51:20]

Dry run: This issue passed the CQ dry run.

[afakhry, 2016-12-07 17:24:34]

Description was changed from

==========
Prevent the pre-session-restore log spam

Avoid using merge_session_throttling_utils::ShouldDelayRequestForProfile() which
spams the logs with warnings and changes the state of the profile, and instead
use
the newly added functions in this CL to show the local NTP if the user profile
hasn't
been finalized yet or session restore is still pending.

BUG=641191
==========

to

==========
Prevent the pre-session-restore log spam

Avoid using merge_session_throttling_utils::ShouldDelayRequestForProfile() which
spams the logs with warnings and changes the state of the profile, and instead
use
the newly added function in this CL to show the local NTP if the session restore
is still pending.

BUG=641191
==========

[afakhry, 2016-12-07 17:25:45]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 17:26:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[afakhry, 2016-12-07 17:27:35]

Xiyuan, as discussed, I updated the CL to pass the tests, and removed the
unnecessary use of path service.

[xiyuan, 2016-12-07 17:34:38]

lgtm

https://codereview.chromium.org/2537263002/diff/100001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/signin/merge_session_throttling_utils.cc
(right):

https://codereview.chromium.org/2537263002/diff/100001/chrome/browser/chromeo...
chrome/browser/chromeos/login/signin/merge_session_throttling_utils.cc:17:
#include "chrome/browser/chromeos/profiles/profile_helper.h"
nit: remove since no longer used?

[afakhry, 2016-12-07 17:49:05]

https://codereview.chromium.org/2537263002/diff/100001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/signin/merge_session_throttling_utils.cc
(right):

https://codereview.chromium.org/2537263002/diff/100001/chrome/browser/chromeo...
chrome/browser/chromeos/login/signin/merge_session_throttling_utils.cc:17:
#include "chrome/browser/chromeos/profiles/profile_helper.h"
On 2016/12/07 17:34:38, xiyuan wrote:
> nit: remove since no longer used?

Done.

[afakhry, 2016-12-07 17:49:09]

The CQ bit was checked by afakhry@chromium.org

[afakhry, 2016-12-07 17:49:10]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org,
xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2537263002/#ps120001
(title: "Nit")

[commit-bot: I haz the power, 2016-12-07 17:49:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 18:29:47]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1481132949646810,
"parent_rev": "c8296dae7492f5b33105087d2c9fd640e0d0b3ae", "commit_rev":
"853ada9c6704c5121214a1bf0f46b60c9e264436"}

[commit-bot: I haz the power, 2016-12-07 18:30:13]

Description was changed from

==========
Prevent the pre-session-restore log spam

Avoid using merge_session_throttling_utils::ShouldDelayRequestForProfile() which
spams the logs with warnings and changes the state of the profile, and instead
use
the newly added function in this CL to show the local NTP if the session restore
is still pending.

BUG=641191
==========

to

==========
Prevent the pre-session-restore log spam

Avoid using merge_session_throttling_utils::ShouldDelayRequestForProfile() which
spams the logs with warnings and changes the state of the profile, and instead
use
the newly added function in this CL to show the local NTP if the session restore
is still pending.

BUG=641191
==========

[commit-bot: I haz the power, 2016-12-07 18:30:15]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-12-07 18:35:05]

Description was changed from

==========
Prevent the pre-session-restore log spam

Avoid using merge_session_throttling_utils::ShouldDelayRequestForProfile() which
spams the logs with warnings and changes the state of the profile, and instead
use
the newly added function in this CL to show the local NTP if the session restore
is still pending.

BUG=641191
==========

to

==========
Prevent the pre-session-restore log spam

Avoid using merge_session_throttling_utils::ShouldDelayRequestForProfile() which
spams the logs with warnings and changes the state of the profile, and instead
use
the newly added function in this CL to show the local NTP if the session restore
is still pending.

BUG=641191

Committed: https://crrev.com/50ade576fb3292ed44ba4d8e3e1d1a999840da82
Cr-Commit-Position: refs/heads/master@{#437013}
==========

[commit-bot: I haz the power, 2016-12-07 18:35:06]

Patchset 6 (id:??) landed as
https://crrev.com/50ade576fb3292ed44ba4d8e3e1d1a999840da82
Cr-Commit-Position: refs/heads/master@{#437013}

[Wez, 2016-12-08 18:33:25]

wez@chromium.org changed reviewers:
+ wez@chromium.org

[Wez, 2016-12-08 18:33:26]

https://codereview.chromium.org/2537263002/diff/120001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/signin/merge_session_throttling_utils.cc
(right):

https://codereview.chromium.org/2537263002/diff/120001/chrome/browser/chromeo...
chrome/browser/chromeos/login/signin/merge_session_throttling_utils.cc:189:
return false;
Is |false| the correct value in this case? What does it even mean to call this
for a null profile?

https://codereview.chromium.org/2537263002/diff/120001/chrome/browser/chromeo...
chrome/browser/chromeos/login/signin/merge_session_throttling_utils.cc:196:
switch (login_manager->state()) {
nit: This would be easier to read as an if(), rather than a switch.