Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2560013002:
Remove UI_DEVTOOLS_EXPORT from class and add it to static methods (Closed)
|
Created:
4 years ago by Sarmad Hashmi Modified:
4 years ago Reviewers:
sadrul CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove UI_DEVTOOLS_EXPORT from class and add it to static methods
The error was caused because static methods in devtools_server.h were
not marked UI_DEVTOOLS_EXPORT. We cannot mark them as such if the whole
class is already marked. Therefore, we need to remove the export from the
class and add it to the static methods.
BUG=669352
Committed: https://crrev.com/c9d4abeb958fde2ab943e4e32d445ae695d71630
Cr-Commit-Position: refs/heads/master@{#437338}
Patch Set 1 #Patch Set 2 : Remove EXPORT from class and add it to static methods #Messages
Total messages: 18 (12 generated)
The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove EXPORT from class and add it to static methods The error was caused because static methods in devtools_server.h were not marked UI_DEVTOOLS_EXPORT. We cannot mark them as such if the whole class is already marked. Therefore, we need to remove the export from the class and add it to the static methods. BUG=669352 ========== to ========== Remove UI_DEVTOOLS_EXPORT from class and add it to static methods The error was caused because static methods in devtools_server.h were not marked UI_DEVTOOLS_EXPORT. We cannot mark them as such if the whole class is already marked. Therefore, we need to remove the export from the class and add it to the static methods. BUG=669352 ==========
The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
mhashmi@chromium.org changed reviewers: + sadrul@chromium.org
PTAL sadrul@! Just fixing the minor bug.
PTAL sadrul@! Just fixing the minor bug.
lgtm
The CQ bit was checked by mhashmi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481230037778780,
"parent_rev": "9e9a595e71e456c81efa18c29ced70cc66805d45", "commit_rev":
"b892d5bce4cbaded2dc52b631f5abd87f78ebb09"}
Message was sent while issue was closed.
Description was changed from ========== Remove UI_DEVTOOLS_EXPORT from class and add it to static methods The error was caused because static methods in devtools_server.h were not marked UI_DEVTOOLS_EXPORT. We cannot mark them as such if the whole class is already marked. Therefore, we need to remove the export from the class and add it to the static methods. BUG=669352 ========== to ========== Remove UI_DEVTOOLS_EXPORT from class and add it to static methods The error was caused because static methods in devtools_server.h were not marked UI_DEVTOOLS_EXPORT. We cannot mark them as such if the whole class is already marked. Therefore, we need to remove the export from the class and add it to the static methods. BUG=669352 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove UI_DEVTOOLS_EXPORT from class and add it to static methods The error was caused because static methods in devtools_server.h were not marked UI_DEVTOOLS_EXPORT. We cannot mark them as such if the whole class is already marked. Therefore, we need to remove the export from the class and add it to the static methods. BUG=669352 ========== to ========== Remove UI_DEVTOOLS_EXPORT from class and add it to static methods The error was caused because static methods in devtools_server.h were not marked UI_DEVTOOLS_EXPORT. We cannot mark them as such if the whole class is already marked. Therefore, we need to remove the export from the class and add it to the static methods. BUG=669352 Committed: https://crrev.com/c9d4abeb958fde2ab943e4e32d445ae695d71630 Cr-Commit-Position: refs/heads/master@{#437338} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c9d4abeb958fde2ab943e4e32d445ae695d71630 Cr-Commit-Position: refs/heads/master@{#437338} |
