Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: components/ui_devtools/devtools_server.h

Issue 2560013002: Remove UI_DEVTOOLS_EXPORT from class and add it to static methods (Closed)
Patch Set: Remove EXPORT from class and add it to static methods Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ui_devtools/devtools_server.h
diff --git a/components/ui_devtools/devtools_server.h b/components/ui_devtools/devtools_server.h
index 3f6ca85ba656f1fd349e96f348d48a1d863ec8c0..4060184fc108bc5905ec9f8e9a21210753319fac 100644
--- a/components/ui_devtools/devtools_server.h
+++ b/components/ui_devtools/devtools_server.h
@@ -20,19 +20,18 @@
namespace ui {
namespace devtools {
-class UI_DEVTOOLS_EXPORT UiDevToolsServer
- : public NON_EXPORTED_BASE(net::HttpServer::Delegate) {
+class UiDevToolsServer : public net::HttpServer::Delegate {
public:
~UiDevToolsServer() override;
// Returns an empty unique_ptr if ui devtools flag isn't enabled or if a
// server instance has already been created.
- static std::unique_ptr<UiDevToolsServer> Create(
+ static UI_DEVTOOLS_EXPORT std::unique_ptr<UiDevToolsServer> Create(
scoped_refptr<base::SingleThreadTaskRunner> io_thread_task_runner);
// Returns a list of attached UiDevToolsClient name + URL
using NameUrlPair = std::pair<std::string, std::string>;
- static std::vector<NameUrlPair> GetClientNamesAndUrls();
+ static UI_DEVTOOLS_EXPORT std::vector<NameUrlPair> GetClientNamesAndUrls();
void AttachClient(std::unique_ptr<UiDevToolsClient> client);
void SendOverWebSocket(int connection_id, const String& message);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698