Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1495)

Unified Diff: Source/web/WorkerPermissionClient.h

Issue 255983003: Oilpan: Move all supplements of Page, Document, and WorkerClients to the managed heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WorkerPermissionClient.h
diff --git a/Source/web/WorkerPermissionClient.h b/Source/web/WorkerPermissionClient.h
index adf950959d37142c9db7654d3ec6141218f78ef4..e7599152d3d3cfa4cc8494d79511a11343cae744 100644
--- a/Source/web/WorkerPermissionClient.h
+++ b/Source/web/WorkerPermissionClient.h
@@ -45,9 +45,10 @@ class WebPermissionCallbacks;
class WebString;
class WebWorkerPermissionClientProxy;
-class WorkerPermissionClient FINAL : public WebCore::Supplement<WebCore::WorkerClients> {
+class WorkerPermissionClient FINAL : public NoBaseWillBeGarbageCollectedFinalized<WorkerPermissionClient>, public WillBeHeapSupplement<WebCore::WorkerClients> {
haraken 2014/04/30 02:41:22 This client looks nice -- it inherits from both No
zerny-chromium 2014/04/30 08:29:34 I've followed the alternative rule: place the GC b
+ WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(WorkerPermissionClient);
public:
- static PassOwnPtr<WorkerPermissionClient> create(PassOwnPtr<WebWorkerPermissionClientProxy>);
+ static PassOwnPtrWillBeRawPtr<WorkerPermissionClient> create(PassOwnPtr<WebWorkerPermissionClientProxy>);
virtual ~WorkerPermissionClient();

Powered by Google App Engine
This is Rietveld 408576698