Oilpan: Move all supplements of Page, Document, and WorkerClients to the managed heap.

Source/web/WorkerPermissionClient.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 27 matching lines @@
 class ExecutionContext;
 }
 
 namespace blink {
 
 class WebFrame;
 class WebPermissionCallbacks;
 class WebString;
 class WebWorkerPermissionClientProxy;
 
-class WorkerPermissionClient FINAL : public WebCore::Supplement<WebCore::WorkerClients> {
+class WorkerPermissionClient FINAL : public NoBaseWillBeGarbageCollectedFinalized<WorkerPermissionClient>, public WillBeHeapSupplement<WebCore::WorkerClients> {

[haraken, 2014/04/30 02:41:22]

This client looks nice -- it inherits from both
NoBaseWillBeGarbageCollectedFinalized and HeapSupplement. It would be consistent
if all clients follow the rule :)

[zerny-chromium, 2014/04/30 08:29:34]

I've followed the alternative rule: place the GC base at the left-most outermost
position that is actually allocatable. The intermediates are really interfaces
and can remain mixins.

+    WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(WorkerPermissionClient);
 public:
-    static PassOwnPtr<WorkerPermissionClient> create(PassOwnPtr<WebWorkerPermissionClientProxy>);
+    static PassOwnPtrWillBeRawPtr<WorkerPermissionClient> create(PassOwnPtr<WebWorkerPermissionClientProxy>);
 
     virtual ~WorkerPermissionClient();
 
     bool allowDatabase(const WebString& name, const WebString& displayName, unsigned long estimatedSize);
     bool allowFileSystem();
     void requestFileSystemAccess(const WebPermissionCallbacks&);
     bool allowIndexedDB(const WebString& name);
 
     static const char* supplementName();
     static WorkerPermissionClient* from(WebCore::ExecutionContext&);
 
     virtual void trace(WebCore::Visitor*) OVERRIDE { }
 
 private:
     explicit WorkerPermissionClient(PassOwnPtr<WebWorkerPermissionClientProxy>);
 
     OwnPtr<WebWorkerPermissionClientProxy> m_proxy;
 };
 
 void providePermissionClientToWorker(WebCore::WorkerClients*, PassOwnPtr<WebWorkerPermissionClientProxy>);
 
 } // namespace blink
 
 #endif // WorkerPermissionClient_h