Source/modules/screen_orientation/ScreenOrientationController.cpp - Issue 255983003: Oilpan: Move all supplements of Page, Document, and WorkerClients to the managed heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/screen_orientation/ScreenOrientationController.cpp

Issue 255983003: Oilpan: Move all supplements of Page, Document, and WorkerClients to the managed heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: review comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/push_messaging/PushController.h ('K') | « Source/modules/screen_orientation/ScreenOrientationController.h ('k') | Source/modules/serviceworkers/ServiceWorkerContainerClient.h » ('j') | Source/modules/webdatabase/DatabaseClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/screen_orientation/ScreenOrientationController.cpp

diff --git a/Source/modules/screen_orientation/ScreenOrientationController.cpp b/Source/modules/screen_orientation/ScreenOrientationController.cpp

index 0de3398ec4bf0517ff840d695ff954157ac11cd0..a04ab73c0967936599eaea3acb92d2bb7b840f2f 100644

--- a/Source/modules/screen_orientation/ScreenOrientationController.cpp

+++ b/Source/modules/screen_orientation/ScreenOrientationController.cpp

@@ -23,7 +23,7 @@ ScreenOrientationController& ScreenOrientationController::from(Document& documen

ScreenOrientationController* controller = static_cast<ScreenOrientationController*>(DocumentSupplement::from(document, supplementName()));

if (!controller) {

controller = new ScreenOrientationController(document);

- DocumentSupplement::provideTo(document, supplementName(), adoptPtr(controller));

+ DocumentSupplement::provideTo(document, supplementName(), adoptPtrWillBeNoop(controller));

}

return *controller;

}