Source/modules/webdatabase/DatabaseClient.h - Issue 255983003: Oilpan: Move all supplements of Page, Document, and WorkerClients to the managed heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webdatabase/DatabaseClient.h

Issue 255983003: Oilpan: Move all supplements of Page, Document, and WorkerClients to the managed heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: review comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/screen_orientation/ScreenOrientationController.cpp ('K') | « Source/modules/vibration/NavigatorVibration.cpp ('k') | Source/modules/webdatabase/DatabaseClient.cpp » ('j') | Source/web/DatabaseClientImpl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webdatabase/DatabaseClient.h

diff --git a/Source/modules/webdatabase/DatabaseClient.h b/Source/modules/webdatabase/DatabaseClient.h

index eb1c79aa98c703566069e11aa701e6b12a9c30bc..5eb2bae7157981c7969f0525850a7c789bb7f7fd 100644

--- a/Source/modules/webdatabase/DatabaseClient.h

+++ b/Source/modules/webdatabase/DatabaseClient.h

@@ -43,7 +43,8 @@ class ExecutionContext;

class InspectorDatabaseAgent;

class WorkerClients;

-class DatabaseClient : public Supplement<Page>, public Supplement<WorkerClients> {

+class GC_PLUGIN_IGNORE("http://crbug.com/367712") DatabaseClient;

+class DatabaseClient : public WillBeHeapSupplement<Page>, public WillBeHeapSupplement<WorkerClients> {

WTF_MAKE_NONCOPYABLE(DatabaseClient);

public:

DatabaseClient();

@@ -62,8 +63,8 @@ private:

InspectorDatabaseAgent* m_inspectorAgent;

haraken 2014/04/30 02:41:22 This raw pointer looks safe because the Page owns

};

-void provideDatabaseClientTo(Page&, PassOwnPtr<DatabaseClient>);

-void provideDatabaseClientToWorker(WorkerClients*, PassOwnPtr<DatabaseClient>);

+void provideDatabaseClientTo(Page&, PassOwnPtrWillBeRawPtr<DatabaseClient>);

+void provideDatabaseClientToWorker(WorkerClients*, PassOwnPtrWillBeRawPtr<DatabaseClient>);

} // namespace WebCore