Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Issue 2559703002: Loading: split MockResourceClients into multiple files type by type (Closed)

Created:
4 years ago by Takashi Toyoshima
Modified:
4 years ago
CC:
chromium-reviews, tyoshino+watch_chromium.org, Yoav Weiss, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Loading: split MockResourceClients into multiple files type by type This patch splits MockResourceClients into MockResourceClient and MockImageResourceClient, because MemoryCacheTest and ResourceFetcherTest just need MockResourceClient and do not want to depend on MockImageResourceClient that has a dependency to ImageResource. BUG=655920 Committed: https://crrev.com/e3d284d7654727b708bddce7b28bb205a6076ca1 Cr-Commit-Position: refs/heads/master@{#438109}

Patch Set 1 #

Patch Set 2 : [rebase to trunk] #

Messages

Total messages: 25 (17 generated)
Takashi Toyoshima
ptal
4 years ago (2016-12-07 12:31:55 UTC) #3
hiroshige
lgtm.
4 years ago (2016-12-12 14:36:27 UTC) #4
yhirano
lgtm > This patch split splits
4 years ago (2016-12-13 03:49:42 UTC) #5
Takashi Toyoshima
+kouhei for BUIDL.gn
4 years ago (2016-12-13 07:46:25 UTC) #10
kouhei (in TOK)
lgtm rs
4 years ago (2016-12-13 09:17:41 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559703002/20001
4 years ago (2016-12-13 09:20:43 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 09:25:13 UTC) #23
commit-bot: I haz the power
4 years ago (2016-12-13 09:29:20 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e3d284d7654727b708bddce7b28bb205a6076ca1
Cr-Commit-Position: refs/heads/master@{#438109}

Powered by Google App Engine
This is Rietveld 408576698