Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: tools/run-bisect-perf-regression.py

Issue 255963002: On Windows XP platform, don't run GOMA service. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/run-bisect-perf-regression.py
diff --git a/tools/run-bisect-perf-regression.py b/tools/run-bisect-perf-regression.py
index ba3a6c8b281298ac765adaa41f4eb244692b0cd3..be5ef606927ffd466a0f889a939b1b08cada3ba8 100755
--- a/tools/run-bisect-perf-regression.py
+++ b/tools/run-bisect-perf-regression.py
@@ -15,6 +15,7 @@ directory provided, and run the bisect-perf-regression.py script there.
import imp
import optparse
import os
+import platform
import subprocess
import sys
import traceback
@@ -388,6 +389,13 @@ def _RunBisectionScript(config, working_directory, path_to_file, path_to_goma,
cmd.extend(['--target_platform', 'android'])
if path_to_goma:
+ # crbug.com/330900. For Windows XP platforms, GOMA service is not supported.
+ # Moreover we don't compile chrome when gs_bucket flag is set instead
+ # use builds archives, therefore ignore GOMA service for Windows XP.
+ if config.get('gs_bucket') and platform.release() == 'XP':
+ print ('Goma doesn\'t have a win32 binary, therefore it is not supported '
+ 'on Windows XP platform. Please refer to crbug.com/330900.')
+ path_to_goma = None
cmd.append('--use_goma')
if path_to_extra_src:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698