Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: tools/run-bisect-perf-regression.py

Issue 255963002: On Windows XP platform, don't run GOMA service. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Run Performance Test Bisect Tool 6 """Run Performance Test Bisect Tool
7 7
8 This script is used by a trybot to run the src/tools/bisect-perf-regression.py 8 This script is used by a trybot to run the src/tools/bisect-perf-regression.py
9 script with the parameters specified in run-bisect-perf-regression.cfg. It will 9 script with the parameters specified in run-bisect-perf-regression.cfg. It will
10 check out a copy of the depot in a subdirectory 'bisect' of the working 10 check out a copy of the depot in a subdirectory 'bisect' of the working
11 directory provided, and run the bisect-perf-regression.py script there. 11 directory provided, and run the bisect-perf-regression.py script there.
12 12
13 """ 13 """
14 14
15 import imp 15 import imp
16 import optparse 16 import optparse
17 import os 17 import os
18 import platform
18 import subprocess 19 import subprocess
19 import sys 20 import sys
20 import traceback 21 import traceback
21 22
22 import bisect_utils 23 import bisect_utils
23 bisect = imp.load_source('bisect-perf-regression', 24 bisect = imp.load_source('bisect-perf-regression',
24 os.path.join(os.path.abspath(os.path.dirname(sys.argv[0])), 25 os.path.join(os.path.abspath(os.path.dirname(sys.argv[0])),
25 'bisect-perf-regression.py')) 26 'bisect-perf-regression.py'))
26 27
27 28
(...skipping 353 matching lines...) Expand 10 before | Expand all | Expand 10 after
381 print 382 print
382 return 1 383 return 1
383 384
384 if 'android' in config['command']: 385 if 'android' in config['command']:
385 if 'android-chrome' in config['command']: 386 if 'android-chrome' in config['command']:
386 cmd.extend(['--target_platform', 'android-chrome']) 387 cmd.extend(['--target_platform', 'android-chrome'])
387 else: 388 else:
388 cmd.extend(['--target_platform', 'android']) 389 cmd.extend(['--target_platform', 'android'])
389 390
390 if path_to_goma: 391 if path_to_goma:
392 # crbug.com/330900. For Windows XP platforms, GOMA service is not supported.
393 # Moreover we don't compile chrome when gs_bucket flag is set instead
394 # use builds archives, therefore ignore GOMA service for Windows XP.
395 if config.get('gs_bucket') and platform.release() == 'XP':
396 print ('Goma doesn\'t have a win32 binary, therefore it is not supported '
397 'on Windows XP platform. Please refer to crbug.com/330900.')
398 path_to_goma = None
391 cmd.append('--use_goma') 399 cmd.append('--use_goma')
392 400
393 if path_to_extra_src: 401 if path_to_extra_src:
394 cmd.extend(['--extra_src', path_to_extra_src]) 402 cmd.extend(['--extra_src', path_to_extra_src])
395 403
396 # These flags are used to download build archives from cloud storage if 404 # These flags are used to download build archives from cloud storage if
397 # available, otherwise will post a try_job_http request to build it on 405 # available, otherwise will post a try_job_http request to build it on
398 # tryserver. 406 # tryserver.
399 if config.get('gs_bucket'): 407 if config.get('gs_bucket'):
400 if config.get('builder_host') and config.get('builder_port'): 408 if config.get('builder_host') and config.get('builder_port'):
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
500 opts.path_to_goma) 508 opts.path_to_goma)
501 509
502 print 'Error: Could not load config file. Double check your changes to '\ 510 print 'Error: Could not load config file. Double check your changes to '\
503 'run-bisect-perf-regression.cfg/run-perf-test.cfg for syntax errors.' 511 'run-bisect-perf-regression.cfg/run-perf-test.cfg for syntax errors.'
504 print 512 print
505 return 1 513 return 1
506 514
507 515
508 if __name__ == '__main__': 516 if __name__ == '__main__':
509 sys.exit(main()) 517 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698