Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 255963002: On Windows XP platform, don't run GOMA service. (Closed)

Created:
6 years, 8 months ago by prasadv
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

On Windows XP platform, don't run GOMA service. For Windows XP platforms, GOMA service is not supported. Moreover we don't compile chorme when gs_bucket flag is set instead use builds archives, therefore ignore GOMA service for Windows XP. NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266446

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tools/run-bisect-perf-regression.py View 1 2 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
prasadv
6 years, 8 months ago (2014-04-25 20:07:57 UTC) #1
prasadv
6 years, 8 months ago (2014-04-25 20:09:41 UTC) #2
shatch
lgtm https://codereview.chromium.org/255963002/diff/1/tools/run-bisect-perf-regression.py File tools/run-bisect-perf-regression.py (right): https://codereview.chromium.org/255963002/diff/1/tools/run-bisect-perf-regression.py#newcode393 tools/run-bisect-perf-regression.py:393: # Moreover we don't compile chorme when gs_bucket ...
6 years, 8 months ago (2014-04-25 20:11:53 UTC) #3
ghost stip (do not use)
lgtm % simon's comments
6 years, 8 months ago (2014-04-25 20:59:26 UTC) #4
prasadv
The CQ bit was checked by prasadv@chromium.org
6 years, 8 months ago (2014-04-25 22:15:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/prasadv@chromium.org/255963002/30001
6 years, 8 months ago (2014-04-25 22:28:27 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 00:30:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-26 00:30:39 UTC) #8
prasadv
The CQ bit was checked by prasadv@chromium.org
6 years, 8 months ago (2014-04-26 00:35:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/prasadv@chromium.org/255963002/30001
6 years, 8 months ago (2014-04-26 00:41:07 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 06:44:37 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-26 06:44:38 UTC) #12
prasadv
The CQ bit was checked by prasadv@chromium.org
6 years, 8 months ago (2014-04-28 04:23:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/prasadv@chromium.org/255963002/30001
6 years, 8 months ago (2014-04-28 04:24:36 UTC) #14
commit-bot: I haz the power
6 years, 8 months ago (2014-04-28 06:41:23 UTC) #15
Message was sent while issue was closed.
Change committed as 266446

Powered by Google App Engine
This is Rietveld 408576698