Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: net/cert/cert_verify_proc_unittest.cc

Issue 2559623002: Skip CertVerifyProcTest.MacCRLIntermediate on Sierra (Mac OS 10.12) (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/cert_verify_proc_unittest.cc
diff --git a/net/cert/cert_verify_proc_unittest.cc b/net/cert/cert_verify_proc_unittest.cc
index d5ccf60b52a9e63fcd174c654d87161ab471e407..96ce38c4d6653cc44d1fab189965cf5e3af9d5ff 100644
--- a/net/cert/cert_verify_proc_unittest.cc
+++ b/net/cert/cert_verify_proc_unittest.cc
@@ -1403,6 +1403,11 @@ TEST_F(CertVerifyProcTest, CRLSetDuringPathBuilding) {
// The verifier should rollback until it just tries A(B) alone, at which point
// it will pull B(F) & F(E) from the keychain and succeed.
TEST_F(CertVerifyProcTest, MacCRLIntermediate) {
+ if (base::mac::IsAtLeastOS10_12()) {
+ // TODO(crbug.com/671889): Investigate SecTrustSetKeychains issue on Sierra.
+ LOG(INFO) << "Skipping test, SecTrustSetKeychains does not work on 10.12";
+ return;
+ }
const char* const kPath2Files[] = {
"multi-root-A-by-B.pem", "multi-root-B-by-C.pem", "multi-root-C-by-E.pem",
"multi-root-E-by-E.pem"};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698