Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: net/cert/cert_verify_proc_unittest.cc

Issue 2559623002: Skip CertVerifyProcTest.MacCRLIntermediate on Sierra (Mac OS 10.12) (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/cert/cert_verify_proc.h" 5 #include "net/cert/cert_verify_proc.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/callback_helpers.h" 9 #include "base/callback_helpers.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 1385 matching lines...) Expand 10 before | Expand all | Expand 10 after
1396 // 1. A(B) -> B(C) -> C(E) -> E(E) 1396 // 1. A(B) -> B(C) -> C(E) -> E(E)
1397 // 2. A(B) -> B(F) -> F(E) -> E(E) 1397 // 2. A(B) -> B(F) -> F(E) -> E(E)
1398 // 1398 //
1399 // A(B) -> B(C) -> C(E) is supplied to the verifier. 1399 // A(B) -> B(C) -> C(E) is supplied to the verifier.
1400 // B(F) and F(E) are supplied in a test keychain. 1400 // B(F) and F(E) are supplied in a test keychain.
1401 // C is blocked by a CRLset. 1401 // C is blocked by a CRLset.
1402 // 1402 //
1403 // The verifier should rollback until it just tries A(B) alone, at which point 1403 // The verifier should rollback until it just tries A(B) alone, at which point
1404 // it will pull B(F) & F(E) from the keychain and succeed. 1404 // it will pull B(F) & F(E) from the keychain and succeed.
1405 TEST_F(CertVerifyProcTest, MacCRLIntermediate) { 1405 TEST_F(CertVerifyProcTest, MacCRLIntermediate) {
1406 if (base::mac::IsAtLeastOS10_12()) {
1407 // TODO(crbug.com/671889): Investigate SecTrustSetKeychains issue on Sierra.
1408 LOG(INFO) << "Skipping test, SecTrustSetKeychains does not work on 10.12";
1409 return;
1410 }
1406 const char* const kPath2Files[] = { 1411 const char* const kPath2Files[] = {
1407 "multi-root-A-by-B.pem", "multi-root-B-by-C.pem", "multi-root-C-by-E.pem", 1412 "multi-root-A-by-B.pem", "multi-root-B-by-C.pem", "multi-root-C-by-E.pem",
1408 "multi-root-E-by-E.pem"}; 1413 "multi-root-E-by-E.pem"};
1409 CertificateList path_2_certs; 1414 CertificateList path_2_certs;
1410 ASSERT_NO_FATAL_FAILURE(LoadCertificateFiles(kPath2Files, &path_2_certs)); 1415 ASSERT_NO_FATAL_FAILURE(LoadCertificateFiles(kPath2Files, &path_2_certs));
1411 1416
1412 const char* const kPath3Files[] = { 1417 const char* const kPath3Files[] = {
1413 "multi-root-A-by-B.pem", "multi-root-B-by-F.pem", "multi-root-F-by-E.pem", 1418 "multi-root-A-by-B.pem", "multi-root-B-by-F.pem", "multi-root-F-by-E.pem",
1414 "multi-root-E-by-E.pem"}; 1419 "multi-root-E-by-E.pem"};
1415 1420
(...skipping 655 matching lines...) Expand 10 before | Expand all | Expand 10 after
2071 int flags = 0; 2076 int flags = 0;
2072 CertVerifyResult verify_result; 2077 CertVerifyResult verify_result;
2073 int error = Verify(cert.get(), "127.0.0.1", flags, NULL, empty_cert_list_, 2078 int error = Verify(cert.get(), "127.0.0.1", flags, NULL, empty_cert_list_,
2074 &verify_result); 2079 &verify_result);
2075 EXPECT_EQ(OK, error); 2080 EXPECT_EQ(OK, error);
2076 histograms.ExpectTotalCount(kTLSFeatureExtensionHistogram, 0); 2081 histograms.ExpectTotalCount(kTLSFeatureExtensionHistogram, 0);
2077 histograms.ExpectTotalCount(kTLSFeatureExtensionOCSPHistogram, 0); 2082 histograms.ExpectTotalCount(kTLSFeatureExtensionOCSPHistogram, 0);
2078 } 2083 }
2079 2084
2080 } // namespace net 2085 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698