Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2559523005: Remove the AnalysisOptionsProcessor (Closed)

Created:
4 years ago by Brian Wilkerson
Modified:
4 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -1208 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 7 chunks +15 lines, -43 lines 0 comments Download
M pkg/analyzer/lib/plugin/options.dart View 3 chunks +1 line, -31 lines 0 comments Download
M pkg/analyzer/lib/src/context/builder.dart View 4 chunks +6 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/src/plugin/options_plugin.dart View 3 chunks +0 lines, -15 lines 0 comments Download
D pkg/analyzer/lib/src/plugin/plugin_configuration.dart View 1 chunk +0 lines, -198 lines 0 comments Download
M pkg/analyzer/lib/src/task/options.dart View 4 chunks +11 lines, -108 lines 0 comments Download
M pkg/analyzer/test/source/error_processor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/context/builder_test.dart View 8 chunks +9 lines, -85 lines 0 comments Download
D pkg/analyzer/test/src/plugin/plugin_config_test.dart View 1 chunk +0 lines, -127 lines 0 comments Download
M pkg/analyzer/test/src/task/options_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download
D pkg/analyzer_cli/lib/src/boot_loader.dart View 1 chunk +0 lines, -211 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 2 chunks +13 lines, -22 lines 0 comments Download
D pkg/analyzer_cli/lib/src/plugin/plugin_manager.dart View 1 chunk +0 lines, -110 lines 0 comments Download
M pkg/analyzer_cli/test/all.dart View 3 chunks +0 lines, -4 lines 0 comments Download
D pkg/analyzer_cli/test/boot_loader_test.dart View 1 chunk +0 lines, -96 lines 0 comments Download
M pkg/analyzer_cli/test/driver_test.dart View 4 chunks +0 lines, -47 lines 0 comments Download
D pkg/analyzer_cli/test/plugin_manager_test.dart View 1 chunk +0 lines, -93 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
This matches the latest changes in the linter and should fix the original bug.
4 years ago (2016-12-07 18:20:01 UTC) #2
scheglov
LGTM
4 years ago (2016-12-07 18:23:22 UTC) #3
Brian Wilkerson
4 years ago (2016-12-07 18:51:37 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
0ea654a068c03ee791730501dc03b1ba8f821c72 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698