Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Unified Diff: pkg/analyzer/lib/plugin/options.dart

Issue 2559523005: Remove the AnalysisOptionsProcessor (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/context_manager.dart ('k') | pkg/analyzer/lib/src/context/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/plugin/options.dart
diff --git a/pkg/analyzer/lib/plugin/options.dart b/pkg/analyzer/lib/plugin/options.dart
index 632c4d955ec63b7bf72ba8b990a1198c446d32e7..a2f7e1a9d2818417187d36b83ab53a7df3dcb21b 100644
--- a/pkg/analyzer/lib/plugin/options.dart
+++ b/pkg/analyzer/lib/plugin/options.dart
@@ -7,18 +7,10 @@
library analyzer.plugin.options;
import 'package:analyzer/error/listener.dart';
-import 'package:analyzer/src/generated/engine.dart';
import 'package:analyzer/src/plugin/options_plugin.dart';
import 'package:plugin/plugin.dart';
import 'package:yaml/yaml.dart';
-/// The identifier of the extension point that allows plugins to access
-/// options defined in the analysis options file. The object used as an
-/// extension must be an [OptionsProcessor].
-final String OPTIONS_PROCESSOR_EXTENSION_POINT_ID = Plugin.join(
- OptionsPlugin.UNIQUE_IDENTIFIER,
- OptionsPlugin.OPTIONS_PROCESSOR_EXTENSION_POINT);
-
/// The identifier of the extension point that allows plugins to validate
/// options defined in the analysis options file. The object used as an
/// extension must be an [OptionsValidator].
@@ -26,9 +18,7 @@ final String OPTIONS_VALIDATOR_EXTENSION_POINT_ID = Plugin.join(
OptionsPlugin.UNIQUE_IDENTIFIER,
OptionsPlugin.OPTIONS_VALIDATOR_EXTENSION_POINT);
-/// Processes options defined in the analysis options file.
-///
-/// Clients may implement this class when implementing plugins.
+/// Validates options as defined in an analysis options file.
///
/// The options file format is intentionally very open-ended, giving clients
/// utmost flexibility in defining their own options. The only hardfast
@@ -55,29 +45,9 @@ final String OPTIONS_VALIDATOR_EXTENSION_POINT_ID = Plugin.join(
///
/// bool useMultiPackage =
/// options['compiler']['resolver']['useMultiPackage'];
-abstract class OptionsProcessor {
- /// Called when an error occurs in processing options.
- void onError(Exception exception);
-
- /// Called when an options file is processed.
- ///
- /// The options file is processed on analyzer initialization and
- /// subsequently when the file is changed on disk. In the event of a
- /// change notification, note that the notification simply indicates
- /// a change on disk. Content in specific option scopes may or may not
- /// be different. It is up to the implementer to check whether specific
- /// options have changed and to handle those changes appropriately. In
- /// addition to the [options] map, the associated analysis [context] is
- /// provided as well to allow for context-specific configuration.
- void optionsProcessed(AnalysisContext context, Map<String, Object> options);
-}
-
-/// Validates options as defined in an analysis options file.
///
/// Clients may implement this class when implementing plugins.
///
-/// See [OptionsProcessor] for a description of the options file format.
-///
abstract class OptionsValidator {
/// Validate [options], reporting any errors to the given [reporter].
void validate(ErrorReporter reporter, Map<String, YamlNode> options);
« no previous file with comments | « pkg/analysis_server/lib/src/context_manager.dart ('k') | pkg/analyzer/lib/src/context/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698