Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 2559513002: Fix FPDF_GetPageLabel API typo. (Closed)

Created:
4 years ago by dsinclair
Modified:
4 years ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix FPDF_GetPageLabel API typo. The API was originally committed as FPDF_GetPagelLabel but should be FPDF_GetPageLabel. BUG=pdfium:479 Committed: https://pdfium.googlesource.com/pdfium/+/6bdb56cad7f9e31183b90152324281ac52c4563d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M fpdfsdk/fpdfdoc.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/fpdfdoc_embeddertest.cpp View 2 chunks +12 lines, -12 lines 0 comments Download
M fpdfsdk/fpdfview_c_api_test.c View 1 chunk +1 line, -1 line 0 comments Download
M public/fpdf_doc.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
dsinclair
PTAL. This API is new enough that I think we should just fix it. It ...
4 years ago (2016-12-06 16:27:23 UTC) #3
Tom Sepez
lgtm
4 years ago (2016-12-06 17:27:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559513002/1
4 years ago (2016-12-06 17:53:12 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/6bdb56cad7f9e31183b90152324281ac52c4563d
4 years ago (2016-12-06 17:53:33 UTC) #14
Lei Zhang
4 years ago (2016-12-08 06:43:30 UTC) #15
Message was sent while issue was closed.
@_@ lgtm

Powered by Google App Engine
This is Rietveld 408576698