Add API for getting page labels.

Add API for getting page labels.

BUG=pdfium:479
Committed: https://pdfium.googlesource.com/pdfium/+/733e068e077bb59597180bc9b8ff934dd125ffdc

[Lei Zhang, 2016-11-22 11:37:12]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 11:37:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 11:46:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 11:46:14]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-11-22 14:14:58]

dsinclair@chromium.org changed reviewers:
+ dsinclair@chromium.org

[dsinclair, 2016-11-22 14:14:58]

https://codereview.chromium.org/2521843003/diff/1/fpdfsdk/fpdfdoc.cpp
File fpdfsdk/fpdfdoc.cpp (right):

https://codereview.chromium.org/2521843003/diff/1/fpdfsdk/fpdfdoc.cpp#newcode68
fpdfsdk/fpdfdoc.cpp:68: FXSYS_memcpy(buffer, encodedText.c_str(), len);
Doesn't this need to copy len+1 to get the \0?

https://codereview.chromium.org/2521843003/diff/1/fpdfsdk/fpdfdoc.cpp#newcode406
fpdfsdk/fpdfdoc.cpp:406: CFX_WideString text = label.GetLabel(page_index);
Don't need to store text as it's only used once.

https://codereview.chromium.org/2521843003/diff/1/public/fpdf_doc.h
File public/fpdf_doc.h (right):

https://codereview.chromium.org/2521843003/diff/1/public/fpdf_doc.h#newcode307
public/fpdf_doc.h:307: //   page_index  - the index of the page.
0-based ?

[Lei Zhang, 2016-11-23 00:20:43]

https://codereview.chromium.org/2521843003/diff/1/fpdfsdk/fpdfdoc.cpp
File fpdfsdk/fpdfdoc.cpp (right):

https://codereview.chromium.org/2521843003/diff/1/fpdfsdk/fpdfdoc.cpp#newcode68
fpdfsdk/fpdfdoc.cpp:68: FXSYS_memcpy(buffer, encodedText.c_str(), len);
On 2016/11/22 14:14:58, dsinclair wrote:
> Doesn't this need to copy len+1 to get the \0?

This is lifted out of FPDFBookmark_GetTitle(), and that has unit tests...

So I don't think we can change the APIs at this point. All we can do is update
the documentation. FPDFAction_GetFilePath() is wrong as well.

[Lei Zhang, 2016-11-23 01:53:17]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 01:53:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-11-23 01:53:43]

PTAL. CPDF_PageLabel needed a little work.

https://codereview.chromium.org/2521843003/diff/1/fpdfsdk/fpdfdoc.cpp
File fpdfsdk/fpdfdoc.cpp (right):

https://codereview.chromium.org/2521843003/diff/1/fpdfsdk/fpdfdoc.cpp#newcode68
fpdfsdk/fpdfdoc.cpp:68: FXSYS_memcpy(buffer, encodedText.c_str(), len);
On 2016/11/22 14:14:58, dsinclair wrote:
> Doesn't this need to copy len+1 to get the \0?

UTF16LE_Encode() already added a double NUL.

https://codereview.chromium.org/2521843003/diff/1/fpdfsdk/fpdfdoc.cpp#newcode406
fpdfsdk/fpdfdoc.cpp:406: CFX_WideString text = label.GetLabel(page_index);
On 2016/11/22 14:14:58, dsinclair wrote:
> Don't need to store text as it's only used once.

Done.

https://codereview.chromium.org/2521843003/diff/1/public/fpdf_doc.h
File public/fpdf_doc.h (right):

https://codereview.chromium.org/2521843003/diff/1/public/fpdf_doc.h#newcode307
public/fpdf_doc.h:307: //   page_index  - the index of the page.
On 2016/11/22 14:14:58, dsinclair wrote:
> 0-based ?

Done.

https://codereview.chromium.org/2521843003/diff/40001/fpdfsdk/fpdfdoc_embedde...
File fpdfsdk/fpdfdoc_embeddertest.cpp (right):

https://codereview.chromium.org/2521843003/diff/40001/fpdfsdk/fpdfdoc_embedde...
fpdfsdk/fpdfdoc_embeddertest.cpp:184:
EXPECT_TRUE(OpenDocument("page_labels.pdf"));
Created in Acrobat.

[commit-bot: I haz the power, 2016-11-23 02:03:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 02:03:33]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-11-23 13:52:21]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-11-23 13:52:22]

lgtm

[commit-bot: I haz the power, 2016-11-23 13:52:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 13:52:40]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479909141783960,
"parent_rev": "1a7534a1a477323f7b8497e359f6af6e9bd54cd5", "commit_rev":
"733e068e077bb59597180bc9b8ff934dd125ffdc"}

[commit-bot: I haz the power, 2016-11-23 13:52:44]

Description was changed from

==========
Add API for getting page labels.

BUG=pdfium:479
==========

to

==========
Add API for getting page labels.

BUG=pdfium:479

Committed:
https://pdfium.googlesource.com/pdfium/+/733e068e077bb59597180bc9b8ff934dd125...
==========

[commit-bot: I haz the power, 2016-11-23 13:52:45]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/733e068e077bb59597180bc9b8ff934dd125...