[1/5] Pass transformed rasterization policy from Blink

[1/5] Pass transformed rasterization policy from Blink

This CL adds an "allow transformed rasterization" input flag to cc layers,
and implements a policy in Blink to decide when to enable to flag.

With existing implementation in cc, layers are always rasterized in some
scaled layer space. The idea is that scaled local space may not always align
to target surface pixel-by-pixel. Rasterizing in such space could result in
resampling error at draw time. With this flag enabled, cc would be allowed
to choose arbitrary space to raster the layer for better draw quality.

This CL only enables the flag for layers that are indirectly composited
(e.g. due to children, overlapping, etc...). Such layer by itself would not
be composited, and Skia would have raster it in device pixel space. Therefore
these are good candidates for cc to raster in target space as well.

The flag currently does nothing. The actual transformed rasterization will
be implemented in followup patches.

BUG=521364
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2559413002
Cr-Commit-Position: refs/heads/master@{#461561}
Committed: https://chromium.googlesource.com/chromium/src/+/f0cb63ee25776d29838be8782ce9adb607010ce8

[trchen, 2016-12-09 02:54:25]

Description was changed from

==========
[1/6] Pass transformed rasterization policy from Blink
==========

to

==========
[1/6] Pass transformed rasterization policy from Blink
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[trchen, 2016-12-09 02:54:25]

Description was changed from

==========
[1/6] Pass transformed rasterization policy from Blink
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
[1/6] Pass transformed rasterization policy from Blink
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[enne (OOO), 2017-01-03 22:53:00]

enne@chromium.org changed reviewers:
+ enne@chromium.org

[enne (OOO), 2017-01-03 22:53:01]

https://codereview.chromium.org/2559413002/diff/1/cc/layers/picture_layer.h
File cc/layers/picture_layer.h (right):

https://codereview.chromium.org/2559413002/diff/1/cc/layers/picture_layer.h#n...
cc/layers/picture_layer.h:88: bool UseTransformedRasterization() const;
style nit: maybe this should be "ShouldUseTransformedRasterization".  Use sounds
like a verb (to start using it) here rather than a query about whether it should
be used.

https://codereview.chromium.org/2559413002/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/WebContentLayer.h (right):

https://codereview.chromium.org/2559413002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/WebContentLayer.h:42: // origin aligned to
local layer space, optionally with an uniform scale.
a uniform

[trchen, 2017-03-28 21:39:28]

Description was changed from

==========
[1/6] Pass transformed rasterization policy from Blink
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
[1/5] Pass transformed rasterization policy from Blink
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[trchen, 2017-03-28 21:39:44]

Description was changed from

==========
[1/5] Pass transformed rasterization policy from Blink
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
[1/5] Pass transformed rasterization policy from Blink
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[trchen, 2017-03-28 22:42:11]

Description was changed from

==========
[1/5] Pass transformed rasterization policy from Blink
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
[1/5] Pass transformed rasterization policy from Blink

This CL adds an "allow transformed rasterization" input flag to cc layers,
and implements a policy in Blink to decide when to enable to flag.

With existing implementation in cc, layers are always rasterized in some
scaled layer space. The idea is that scaled local space may not always align
to target surface pixel-by-pixel. Rasterizing in such space could result in
resampling error at draw time. With this flag enabled, cc would be allowed
to choose arbitrary space to raster the layer for better draw quality.

This CL only enables the flag for layers that are indirectly composited
(e.g. due to children, overlapping, etc...). Such layer by itself would not
be composited, and Skia would have raster it in device pixel space. Therefore
these are good candidates for cc to raster in target space as well.

The flag currently does nothing. The actual transformed rasterization will
be implemented in followup patches.

BUG=521364

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[enne (OOO), 2017-03-29 13:02:02]

lgtm

[trchen, 2017-03-31 19:29:22]

trchen@chromium.org changed reviewers:
+ chrishtr@chromium.org

[trchen, 2017-03-31 19:29:56]

Oops, I forgot third_party/WebKit. chrishtr@ could you take a look? Thanks!

[chrishtr, 2017-04-03 20:47:09]

lgtm

[trchen, 2017-04-03 20:58:43]

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 20:59:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 22:27:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 22:27:53]

Dry run: This issue passed the CQ dry run.

[trchen, 2017-04-03 22:31:45]

The CQ bit was checked by trchen@chromium.org

[trchen, 2017-04-03 22:31:45]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2559413002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-03 22:33:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 22:38:22]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491258705394970,
"parent_rev": "88953d9c7663f797a6c92b8b764812d0e84ef8d9", "commit_rev":
"f0cb63ee25776d29838be8782ce9adb607010ce8"}

[commit-bot: I haz the power, 2017-04-03 22:39:26]

Description was changed from

==========
[1/5] Pass transformed rasterization policy from Blink

This CL adds an "allow transformed rasterization" input flag to cc layers,
and implements a policy in Blink to decide when to enable to flag.

With existing implementation in cc, layers are always rasterized in some
scaled layer space. The idea is that scaled local space may not always align
to target surface pixel-by-pixel. Rasterizing in such space could result in
resampling error at draw time. With this flag enabled, cc would be allowed
to choose arbitrary space to raster the layer for better draw quality.

This CL only enables the flag for layers that are indirectly composited
(e.g. due to children, overlapping, etc...). Such layer by itself would not
be composited, and Skia would have raster it in device pixel space. Therefore
these are good candidates for cc to raster in target space as well.

The flag currently does nothing. The actual transformed rasterization will
be implemented in followup patches.

BUG=521364

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
[1/5] Pass transformed rasterization policy from Blink

This CL adds an "allow transformed rasterization" input flag to cc layers,
and implements a policy in Blink to decide when to enable to flag.

With existing implementation in cc, layers are always rasterized in some
scaled layer space. The idea is that scaled local space may not always align
to target surface pixel-by-pixel. Rasterizing in such space could result in
resampling error at draw time. With this flag enabled, cc would be allowed
to choose arbitrary space to raster the layer for better draw quality.

This CL only enables the flag for layers that are indirectly composited
(e.g. due to children, overlapping, etc...). Such layer by itself would not
be composited, and Skia would have raster it in device pixel space. Therefore
these are good candidates for cc to raster in target space as well.

The flag currently does nothing. The actual transformed rasterization will
be implemented in followup patches.

BUG=521364

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2559413002
Cr-Commit-Position: refs/heads/master@{#461561}
Committed:
https://chromium.googlesource.com/chromium/src/+/f0cb63ee25776d29838be8782ce9...
==========

[commit-bot: I haz the power, 2017-04-03 22:39:27]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f0cb63ee25776d29838be8782ce9...