Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2559403002:
[Tracing] Show background parsing runtime statistics in tracing. (Closed)
Description[Tracing] Show background parsing runtime statistics in tracing
When ParseOnBackground is done, we should construct a trace event and dump all
background parsing runtime statistics as argument. In tracing we don't want to
merge it back to to main thread, instead we show the trace event together with
background parsing trace event on script streamer thread track in Trace Viewer.
To perf sheriff: A series of counters ParseBackgroundxxx and
PreparseBackgroundxxx will be taken into account in this patch, thus runtime
statistics graph will increase after this patch gets landed.
BUG=v8:5089
Committed: https://crrev.com/dca99f4fc8b09db9f3fb6f26672817ab73d94144
Cr-Commit-Position: refs/heads/master@{#41658}
Patch Set 1 #Patch Set 2 : Use instant trace event #Messages
Total messages: 30 (21 generated)
The CQ bit was checked by lpy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [Tracing] Show background parsing runtime statistics in tracing When ParseOnBackground is done, we should construct a trace event and dump all background parsing runtime statistics as argument. In tracing we don't want to merge it back to to main thread, instead we show the trace event together with background parsing trace event on script streamer thread track in Trace Viewer. ========== to ========== [Tracing] Show background parsing runtime statistics in tracing When ParseOnBackground is done, we should construct a trace event and dump all background parsing runtime statistics as argument. In tracing we don't want to merge it back to to main thread, instead we show the trace event together with background parsing trace event on script streamer thread track in Trace Viewer. ==========
lpy@chromium.org changed reviewers: + fmeawad@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm Can you assign this to the same bug # that was used to land the runtime stats in tracing?
Description was changed from ========== [Tracing] Show background parsing runtime statistics in tracing When ParseOnBackground is done, we should construct a trace event and dump all background parsing runtime statistics as argument. In tracing we don't want to merge it back to to main thread, instead we show the trace event together with background parsing trace event on script streamer thread track in Trace Viewer. ========== to ========== [Tracing] Show background parsing runtime statistics in tracing When ParseOnBackground is done, we should construct a trace event and dump all background parsing runtime statistics as argument. In tracing we don't want to merge it back to to main thread, instead we show the trace event together with background parsing trace event on script streamer thread track in Trace Viewer. BUG=v8:5089 ==========
lpy@chromium.org changed reviewers: + cbruni@chromium.org
PTAL.
The CQ bit was checked by lpy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by lpy@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from fmeawad@chromium.org Link to the patchset: https://codereview.chromium.org/2559403002/#ps20001 (title: "Use instant trace event")
The CQ bit was unchecked by lpy@chromium.org
lpy@chromium.org changed reviewers: + adamk@chromium.org
+ adamk@ for parsing/ owner review.
Description was changed from ========== [Tracing] Show background parsing runtime statistics in tracing When ParseOnBackground is done, we should construct a trace event and dump all background parsing runtime statistics as argument. In tracing we don't want to merge it back to to main thread, instead we show the trace event together with background parsing trace event on script streamer thread track in Trace Viewer. BUG=v8:5089 ========== to ========== [Tracing] Show background parsing runtime statistics in tracing When ParseOnBackground is done, we should construct a trace event and dump all background parsing runtime statistics as argument. In tracing we don't want to merge it back to to main thread, instead we show the trace event together with background parsing trace event on script streamer thread track in Trace Viewer. To perf sheriff: A series of counters ParseBackgroundxxx and PreparseBackgroundxxx will be taken into account in this patch, thus runtime statistics graph will increase after this patch gets landed. BUG=v8:5089 ==========
lgtm stamp for parsing
The CQ bit was checked by lpy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481584370701590,
"parent_rev": "373766f3f1951b9e70307dce61196dff94cdbca8", "commit_rev":
"2cb50037c263b8c670517657dacb2ab7a64279a0"}
Message was sent while issue was closed.
Description was changed from ========== [Tracing] Show background parsing runtime statistics in tracing When ParseOnBackground is done, we should construct a trace event and dump all background parsing runtime statistics as argument. In tracing we don't want to merge it back to to main thread, instead we show the trace event together with background parsing trace event on script streamer thread track in Trace Viewer. To perf sheriff: A series of counters ParseBackgroundxxx and PreparseBackgroundxxx will be taken into account in this patch, thus runtime statistics graph will increase after this patch gets landed. BUG=v8:5089 ========== to ========== [Tracing] Show background parsing runtime statistics in tracing When ParseOnBackground is done, we should construct a trace event and dump all background parsing runtime statistics as argument. In tracing we don't want to merge it back to to main thread, instead we show the trace event together with background parsing trace event on script streamer thread track in Trace Viewer. To perf sheriff: A series of counters ParseBackgroundxxx and PreparseBackgroundxxx will be taken into account in this patch, thus runtime statistics graph will increase after this patch gets landed. BUG=v8:5089 Review-Url: https://codereview.chromium.org/2559403002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Tracing] Show background parsing runtime statistics in tracing When ParseOnBackground is done, we should construct a trace event and dump all background parsing runtime statistics as argument. In tracing we don't want to merge it back to to main thread, instead we show the trace event together with background parsing trace event on script streamer thread track in Trace Viewer. To perf sheriff: A series of counters ParseBackgroundxxx and PreparseBackgroundxxx will be taken into account in this patch, thus runtime statistics graph will increase after this patch gets landed. BUG=v8:5089 Review-Url: https://codereview.chromium.org/2559403002 ========== to ========== [Tracing] Show background parsing runtime statistics in tracing When ParseOnBackground is done, we should construct a trace event and dump all background parsing runtime statistics as argument. In tracing we don't want to merge it back to to main thread, instead we show the trace event together with background parsing trace event on script streamer thread track in Trace Viewer. To perf sheriff: A series of counters ParseBackgroundxxx and PreparseBackgroundxxx will be taken into account in this patch, thus runtime statistics graph will increase after this patch gets landed. BUG=v8:5089 Committed: https://crrev.com/dca99f4fc8b09db9f3fb6f26672817ab73d94144 Cr-Commit-Position: refs/heads/master@{#41658} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/dca99f4fc8b09db9f3fb6f26672817ab73d94144 Cr-Commit-Position: refs/heads/master@{#41658} |
