|
|
DescriptionDisable the flaky NetworkQualityEstimator unittest on ios_simulator
NetworkQualityEstimator::TestEffectiveConnectionTypeObserver is disabled on
ios-simulator until it is clear why it is flaky.
BUG=641708
Committed: https://crrev.com/9b0a183012bd52bdd368a32b0849624981511a08
Cr-Commit-Position: refs/heads/master@{#438722}
Patch Set 1 #
Messages
Total messages: 27 (16 generated)
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Disable flaky NQE test on ios-simulator BUG= ========== to ========== Disable the flaky NetworkQualityEstimator unittest on ios_simulator NetworkQualityEstimator::TestEffectiveConnectionTypeObserver is disabled on ios-simulator until it is clear why it is flaky. BUG=641708 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
tbansal@chromium.org changed reviewers: + bengr@chromium.org
bengr: ptal. Thanks.
lgtm
The CQ bit was checked by tbansal@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by tbansal@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by tbansal@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by tbansal@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1481770303771580, "parent_rev": "7f930336f0570d90c07de1aa4402dc8e15fc0848", "commit_rev": "175536be8e1f4b0a7f3efe58d79ab596242992fc"}
Message was sent while issue was closed.
Description was changed from ========== Disable the flaky NetworkQualityEstimator unittest on ios_simulator NetworkQualityEstimator::TestEffectiveConnectionTypeObserver is disabled on ios-simulator until it is clear why it is flaky. BUG=641708 ========== to ========== Disable the flaky NetworkQualityEstimator unittest on ios_simulator NetworkQualityEstimator::TestEffectiveConnectionTypeObserver is disabled on ios-simulator until it is clear why it is flaky. BUG=641708 Review-Url: https://codereview.chromium.org/2559373005 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Disable the flaky NetworkQualityEstimator unittest on ios_simulator NetworkQualityEstimator::TestEffectiveConnectionTypeObserver is disabled on ios-simulator until it is clear why it is flaky. BUG=641708 Review-Url: https://codereview.chromium.org/2559373005 ========== to ========== Disable the flaky NetworkQualityEstimator unittest on ios_simulator NetworkQualityEstimator::TestEffectiveConnectionTypeObserver is disabled on ios-simulator until it is clear why it is flaky. BUG=641708 Committed: https://crrev.com/9b0a183012bd52bdd368a32b0849624981511a08 Cr-Commit-Position: refs/heads/master@{#438722} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9b0a183012bd52bdd368a32b0849624981511a08 Cr-Commit-Position: refs/heads/master@{#438722} |