Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 2559373005: Disable the flaky NetworkQualityEstimator unittest on ios_simulator (Closed)

Created:
4 years ago by tbansal1
Modified:
4 years ago
Reviewers:
bengr
CC:
chromium-reviews, cbentzel+watch_chromium.org, tbansal+watch-nqe_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable the flaky NetworkQualityEstimator unittest on ios_simulator NetworkQualityEstimator::TestEffectiveConnectionTypeObserver is disabled on ios-simulator until it is clear why it is flaky. BUG=641708 Committed: https://crrev.com/9b0a183012bd52bdd368a32b0849624981511a08 Cr-Commit-Position: refs/heads/master@{#438722}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M net/nqe/network_quality_estimator_unittest.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 27 (16 generated)
tbansal1
bengr: ptal. Thanks.
4 years ago (2016-12-12 17:33:52 UTC) #7
bengr
lgtm
4 years ago (2016-12-15 01:27:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559373005/1
4 years ago (2016-12-15 01:35:42 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/315204) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
4 years ago (2016-12-15 01:40:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559373005/1
4 years ago (2016-12-15 01:45:50 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/315215) win_clang on master.tryserver.chromium.win (JOB_FAILED, ...
4 years ago (2016-12-15 01:52:47 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559373005/1
4 years ago (2016-12-15 02:02:24 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/139143)
4 years ago (2016-12-15 02:08:18 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559373005/1
4 years ago (2016-12-15 02:52:02 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 03:07:42 UTC) #25
commit-bot: I haz the power
4 years ago (2016-12-15 03:11:13 UTC) #27
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b0a183012bd52bdd368a32b0849624981511a08
Cr-Commit-Position: refs/heads/master@{#438722}

Powered by Google App Engine
This is Rietveld 408576698