Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 2559373003: Do not call updateDistribution() in Node::assingedSlotForBinding() (Closed)

Created:
4 years ago by hayato
Modified:
4 years ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not call updateDistribution() in Node::assingedSlotForBinding() updateDistribution() is no longer required here since slotname-to-slot hashmap is dynamically updated at the timing of DOM mutations. BUG=671311 Committed: https://crrev.com/5277d3159e5a5ca75fb1306167d6356b99c97e32 Cr-Commit-Position: refs/heads/master@{#437505}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/core/dom/Node.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
hayato
PTAL
4 years ago (2016-12-09 08:11:17 UTC) #5
kochi
lgtm https://codereview.chromium.org/2559373003/diff/1/third_party/WebKit/Source/core/dom/Node.cpp File third_party/WebKit/Source/core/dom/Node.cpp (right): https://codereview.chromium.org/2559373003/diff/1/third_party/WebKit/Source/core/dom/Node.cpp#newcode2303 third_party/WebKit/Source/core/dom/Node.cpp:2303: // assignedSlot doesn't needs to call updateDistribution(). s/needs/need/ ...
4 years ago (2016-12-09 08:29:04 UTC) #7
hayato
fixed
4 years ago (2016-12-09 08:31:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559373003/20001
4 years ago (2016-12-09 08:31:30 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-09 09:45:36 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-09 09:48:20 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5277d3159e5a5ca75fb1306167d6356b99c97e32
Cr-Commit-Position: refs/heads/master@{#437505}

Powered by Google App Engine
This is Rietveld 408576698