Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1543)

Unified Diff: third_party/WebKit/Source/core/dom/Node.cpp

Issue 2559373003: Do not call updateDistribution() in Node::assingedSlotForBinding() (Closed)
Patch Set: fixed Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Node.cpp
diff --git a/third_party/WebKit/Source/core/dom/Node.cpp b/third_party/WebKit/Source/core/dom/Node.cpp
index d5feaa1f73d247f0c0df0b1925e500de1d7eb700..fce91f74a2247863f6b827301943423a61b5d212 100644
--- a/third_party/WebKit/Source/core/dom/Node.cpp
+++ b/third_party/WebKit/Source/core/dom/Node.cpp
@@ -2300,6 +2300,7 @@ StaticNodeList* Node::getDestinationInsertionPoints() {
}
HTMLSlotElement* Node::assignedSlot() const {
+ // assignedSlot doesn't need to call updateDistribution().
DCHECK(!isPseudoElement());
if (ShadowRoot* root = v1ShadowRootOfParent())
return root->ensureSlotAssignment().findSlot(*this);
@@ -2307,7 +2308,7 @@ HTMLSlotElement* Node::assignedSlot() const {
}
HTMLSlotElement* Node::assignedSlotForBinding() {
- updateDistribution();
+ // assignedSlot doesn't need to call updateDistribution().
if (ShadowRoot* root = v1ShadowRootOfParent()) {
if (root->type() == ShadowRootType::Open)
return root->ensureSlotAssignment().findSlot(*this);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698