Allow tree walker to escape roots

Allow tree walker to escape roots

Scenario:
In the launcher subtree of the desktop tree, we have:
dialog
...
  web view
    root web area
    ...
   files button

A dialog with mixed web and views content.

When navigating forward, we search downward and get into the web view and find nothing inside, but when unwinding upward, we stop at the root web area because it gets matched by the root predicate.

In the end, we don't end up on the native views next in document order.

TEST=navigate with ChromeVox keys. Ensure we can get to the buttons.
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/0d5f170fd2d17cad79c2e636ddefab4ff03e6515
Cr-Commit-Position: refs/heads/master@{#437539}

[David Tseng, 2016-12-08 21:58:13]

Description was changed from

==========
Allow tree walker to escape roots

Scenario:
In the launcher subtree of the desktop tree, we have:
dialog
...
  web view
    root web area
    ...
   files button

A dialog with mixed web and views content.

When navigating forward, we search downward and get into the web view and find
nothing inside, but when unwinding upward, we stop at the root web area because
it gets matched by the root predicate.

In the end, we don't end up on the native views next in document order.

TEST=navigate with ChromeVox keys. Ensure we can get to the buttons.
BUG=
==========

to

==========
Allow tree walker to escape roots

Scenario:
In the launcher subtree of the desktop tree, we have:
dialog
...
  web view
    root web area
    ...
   files button

A dialog with mixed web and views content.

When navigating forward, we search downward and get into the web view and find
nothing inside, but when unwinding upward, we stop at the root web area because
it gets matched by the root predicate.

In the end, we don't end up on the native views next in document order.

TEST=navigate with ChromeVox keys. Ensure we can get to the buttons.
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-12-08 21:58:37]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2016-12-08 23:39:32]

lgtm

[David Tseng, 2016-12-08 23:48:29]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-12-08 23:49:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 23:59:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 23:59:16]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[David Tseng, 2016-12-09 14:18:04]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-12-09 14:18:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 15:09:41]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481293084943100,
"parent_rev": "36b4fae51a96aa64908c2fba97c38dee8aad5de2", "commit_rev":
"52e8eadc01a218d89f572456c4cf3c8563721008"}

[commit-bot: I haz the power, 2016-12-09 15:10:05]

Description was changed from

==========
Allow tree walker to escape roots

Scenario:
In the launcher subtree of the desktop tree, we have:
dialog
...
  web view
    root web area
    ...
   files button

A dialog with mixed web and views content.

When navigating forward, we search downward and get into the web view and find
nothing inside, but when unwinding upward, we stop at the root web area because
it gets matched by the root predicate.

In the end, we don't end up on the native views next in document order.

TEST=navigate with ChromeVox keys. Ensure we can get to the buttons.
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Allow tree walker to escape roots

Scenario:
In the launcher subtree of the desktop tree, we have:
dialog
...
  web view
    root web area
    ...
   files button

A dialog with mixed web and views content.

When navigating forward, we search downward and get into the web view and find
nothing inside, but when unwinding upward, we stop at the root web area because
it gets matched by the root predicate.

In the end, we don't end up on the native views next in document order.

TEST=navigate with ChromeVox keys. Ensure we can get to the buttons.
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2559343002
==========

[commit-bot: I haz the power, 2016-12-09 15:10:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-09 15:13:00]

Description was changed from

==========
Allow tree walker to escape roots

Scenario:
In the launcher subtree of the desktop tree, we have:
dialog
...
  web view
    root web area
    ...
   files button

A dialog with mixed web and views content.

When navigating forward, we search downward and get into the web view and find
nothing inside, but when unwinding upward, we stop at the root web area because
it gets matched by the root predicate.

In the end, we don't end up on the native views next in document order.

TEST=navigate with ChromeVox keys. Ensure we can get to the buttons.
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2559343002
==========

to

==========
Allow tree walker to escape roots

Scenario:
In the launcher subtree of the desktop tree, we have:
dialog
...
  web view
    root web area
    ...
   files button

A dialog with mixed web and views content.

When navigating forward, we search downward and get into the web view and find
nothing inside, but when unwinding upward, we stop at the root web area because
it gets matched by the root predicate.

In the end, we don't end up on the native views next in document order.

TEST=navigate with ChromeVox keys. Ensure we can get to the buttons.
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/0d5f170fd2d17cad79c2e636ddefab4ff03e6515
Cr-Commit-Position: refs/heads/master@{#437539}
==========

[commit-bot: I haz the power, 2016-12-09 15:13:00]

Patchset 3 (id:??) landed as
https://crrev.com/0d5f170fd2d17cad79c2e636ddefab4ff03e6515
Cr-Commit-Position: refs/heads/master@{#437539}