Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: media/video/capture/mac/video_capture_device_mac.mm

Issue 255933006: Mac AVFoundation: minor bugfix using QTKit for devices not working with AVF (Blackmagic). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/video/capture/mac/video_capture_device_mac.mm
diff --git a/media/video/capture/mac/video_capture_device_mac.mm b/media/video/capture/mac/video_capture_device_mac.mm
index 1a65e990910aac11cf50c43983ec3d117ac30bf8..6f2271010d19339abd193d1e1413e665537cba5c 100644
--- a/media/video/capture/mac/video_capture_device_mac.mm
+++ b/media/video/capture/mac/video_capture_device_mac.mm
@@ -24,11 +24,12 @@ const size_t kVidPidSize = 4;
// Some devices are not correctly supported in AVFoundation, f.i. Blackmagic,
// see http://crbug.com/347371. The devices are identified by USB Vendor ID and
-// by a characteristic substring of the name, usually the vendor's name.
+// by a characteristic substring of the name, usually the vendor's name. USB VID
+// is written uppercase.
tommi (sloooow) - chröme 2014/04/28 08:17:10 nit: written in uppercase Btw, would it make sens
mcasas 2014/04/28 08:31:20 Yeah I doubted between that and forcing uppercase
const struct NameAndVid {
const char* vid;
const char* name;
-} kBlacklistedCameras[] = { { "a82c", "Blackmagic" } };
+} kBlacklistedCameras[] = { { "A82C", "Blackmagic" } };
const struct Resolution {
const int width;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698