Mac AVFoundation: minor bugfix using QTKit for devices not working with AVF (Blackmagic).

media/video/capture/mac/video_capture_device_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/video/capture/mac/video_capture_device_mac.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/time/time.h"
 #import "media/video/capture/mac/avfoundation_glue.h"
 #import "media/video/capture/mac/platform_video_capturing_mac.h"
 #import "media/video/capture/mac/video_capture_device_avfoundation_mac.h"
 #import "media/video/capture/mac/video_capture_device_qtkit_mac.h"
 
 namespace media {
 
 const int kMinFrameRate = 1;
 const int kMaxFrameRate = 30;
 
 // In device identifiers, the USB VID and PID are stored in 4 bytes each.
 const size_t kVidPidSize = 4;
 
 // Some devices are not correctly supported in AVFoundation, f.i. Blackmagic,
 // see http://crbug.com/347371. The devices are identified by USB Vendor ID and
-// by a characteristic substring of the name, usually the vendor's name.
+// by a characteristic substring of the name, usually the vendor's name. USB VID
+// is written uppercase.

[tommi (sloooow) - chröme, 2014/04/28 08:17:10]

nit: written in uppercase

Btw, would it make sense to have a case insensitive check against the blacklist?

[mcasas, 2014/04/28 08:31:20]

Yeah I doubted between that and forcing uppercase
in the list, but I guess the case-insensitive is more 
robust, so done.

 const struct NameAndVid {
   const char* vid;
   const char* name;
-} kBlacklistedCameras[] = { { "a82c", "Blackmagic" } };
+} kBlacklistedCameras[] = { { "A82C", "Blackmagic" } };
 
 const struct Resolution {
   const int width;
   const int height;
 } kQVGA = { 320, 240 },
   kVGA = { 640, 480 },
   kHD = { 1280, 720 };
 
 const struct Resolution* const kWellSupportedResolutions[] = {
   &kQVGA,
@@ skipping 333 matching lines @@
  if (![capture_device_ setCaptureHeight:capture_format_.frame_size.height()
                                   width:capture_format_.frame_size.width()
                               frameRate:capture_format_.frame_rate]) {
    ReceiveError("Could not configure capture device.");
    return false;
  }
  return true;
 }
 
 } // namespace media