Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 255933006: Mac AVFoundation: minor bugfix using QTKit for devices not working with AVF (Blackmagic). (Closed)

Created:
6 years, 7 months ago by mcasas
Modified:
6 years, 7 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Visibility:
Public.

Description

Mac AVFoundation: minor bugfix using QTKit for devices not working with AVF (Blackmagic). This is a minor bugfix to https://codereview.chromium.org/229063003, changing the comparison of USB VID to ignore the case. BUG=288562, 347371 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266550

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Compare ignoring case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M media/video/capture/mac/video_capture_device_mac.mm View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
mcasas
tommi@: OWNERS stamp please.
6 years, 7 months ago (2014-04-28 08:01:30 UTC) #1
tommi (sloooow) - chröme
https://codereview.chromium.org/255933006/diff/20001/media/video/capture/mac/video_capture_device_mac.mm File media/video/capture/mac/video_capture_device_mac.mm (right): https://codereview.chromium.org/255933006/diff/20001/media/video/capture/mac/video_capture_device_mac.mm#newcode28 media/video/capture/mac/video_capture_device_mac.mm:28: // is written uppercase. nit: written in uppercase Btw, ...
6 years, 7 months ago (2014-04-28 08:17:10 UTC) #2
mcasas
tommi@ PTAL. https://codereview.chromium.org/255933006/diff/20001/media/video/capture/mac/video_capture_device_mac.mm File media/video/capture/mac/video_capture_device_mac.mm (right): https://codereview.chromium.org/255933006/diff/20001/media/video/capture/mac/video_capture_device_mac.mm#newcode28 media/video/capture/mac/video_capture_device_mac.mm:28: // is written uppercase. On 2014/04/28 08:17:10, ...
6 years, 7 months ago (2014-04-28 08:31:20 UTC) #3
tommi (sloooow) - chröme
lgtm
6 years, 7 months ago (2014-04-28 08:45:00 UTC) #4
mcasas
The CQ bit was checked by mcasas@chromium.org
6 years, 7 months ago (2014-04-28 08:53:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/255933006/40001
6 years, 7 months ago (2014-04-28 08:54:25 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 10:39:07 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 7 months ago (2014-04-28 10:39:07 UTC) #8
mcasas
The CQ bit was checked by mcasas@chromium.org
6 years, 7 months ago (2014-04-28 11:14:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/255933006/40001
6 years, 7 months ago (2014-04-28 11:15:10 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 13:59:48 UTC) #11
Message was sent while issue was closed.
Change committed as 266550

Powered by Google App Engine
This is Rietveld 408576698