[net/predictor] Remove unsafe usage of WeakPtrFactory

[net/predictor] Remove unsafe usage of WeakPtrFactory

The post task to delete the predictor on the IO thread comes from the
profile destruction. Thus, callers into the predictor on the UI thread
with *valid* profiles are guaranteed to have their IO thread tasks queued
before the predictor is torn down on the IO thread.

This means we can safely use base::Unretained in place of weak pointers
in these cases.

BUG=671970
Committed: https://crrev.com/b671a5234f41f1784bd261a7c1eb6010434cd2c2
Cr-Commit-Position: refs/heads/master@{#437704}

[Charlie Harrison, 2016-12-09 21:56:32]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 21:57:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2016-12-09 21:57:30]

csharrison@chromium.org changed reviewers:
+ mmenke@chromium.org

[Charlie Harrison, 2016-12-09 21:57:31]

mmenke, here is what we chatted about offline. PTAL?

[mmenke, 2016-12-09 22:01:18]

LGTM

https://codereview.chromium.org/2559323008/diff/1/chrome/browser/net/predicto...
File chrome/browser/net/predictor.cc (right):

https://codereview.chromium.org/2559323008/diff/1/chrome/browser/net/predicto...
chrome/browser/net/predictor.cc:316: // ShutdownOnUIThread, because we must have
a valid profile here. Note that
nit:  --we

https://codereview.chromium.org/2559323008/diff/1/chrome/browser/net/predicto...
chrome/browser/net/predictor.cc:696: // ShutdownOnUIThread, because we have a
valid profile here.
nit: --we

[Charlie Harrison, 2016-12-09 22:03:15]

Thanks, I s/we have/the caller has/

let's CQ it.

[Charlie Harrison, 2016-12-09 22:03:32]

The CQ bit was checked by csharrison@chromium.org

[Charlie Harrison, 2016-12-09 22:03:32]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2559323008/#ps20001
(title: "s/we have/the caller has/g")

[commit-bot: I haz the power, 2016-12-09 22:04:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 00:04:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481321012369640,
"parent_rev": "934e5a5d2ba248391c27171533719fb186822aae", "commit_rev":
"c4723fa73a43cd8072fa7dcf35d28787863d8eae"}

[commit-bot: I haz the power, 2016-12-10 00:04:56]

Description was changed from

==========
[net/predictor] Remove unsafe usage of WeakPtrFactory

The post task to delete the predictor on the IO thread comes from the
profile destruction. Thus, callers into the predictor on the UI thread
with *valid* profiles are guaranteed to have their IO thread tasks queued
before the predictor is torn down on the IO thread.

This means we can safely use base::Unretained in place of weak pointers
in these cases.

BUG=671970
==========

to

==========
[net/predictor] Remove unsafe usage of WeakPtrFactory

The post task to delete the predictor on the IO thread comes from the
profile destruction. Thus, callers into the predictor on the UI thread
with *valid* profiles are guaranteed to have their IO thread tasks queued
before the predictor is torn down on the IO thread.

This means we can safely use base::Unretained in place of weak pointers
in these cases.

BUG=671970

Review-Url: https://codereview.chromium.org/2559323008
==========

[commit-bot: I haz the power, 2016-12-10 00:04:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-12 14:58:52]

Description was changed from

==========
[net/predictor] Remove unsafe usage of WeakPtrFactory

The post task to delete the predictor on the IO thread comes from the
profile destruction. Thus, callers into the predictor on the UI thread
with *valid* profiles are guaranteed to have their IO thread tasks queued
before the predictor is torn down on the IO thread.

This means we can safely use base::Unretained in place of weak pointers
in these cases.

BUG=671970

Review-Url: https://codereview.chromium.org/2559323008
==========

to

==========
[net/predictor] Remove unsafe usage of WeakPtrFactory

The post task to delete the predictor on the IO thread comes from the
profile destruction. Thus, callers into the predictor on the UI thread
with *valid* profiles are guaranteed to have their IO thread tasks queued
before the predictor is torn down on the IO thread.

This means we can safely use base::Unretained in place of weak pointers
in these cases.

BUG=671970

Committed: https://crrev.com/b671a5234f41f1784bd261a7c1eb6010434cd2c2
Cr-Commit-Position: refs/heads/master@{#437704}
==========

[commit-bot: I haz the power, 2016-12-12 14:58:52]

Patchset 2 (id:??) landed as
https://crrev.com/b671a5234f41f1784bd261a7c1eb6010434cd2c2
Cr-Commit-Position: refs/heads/master@{#437704}