Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2559323004: bindings: Stop using forward declarations for typed array in union containers (Closed)

Created:
4 years ago by bashi
Modified:
4 years ago
Reviewers:
haraken, peria, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bindings: Stop using forward declarations for typed array in union containers Typed arrays in blink (e.g. DOMFloat32Array) are typedef of DOMTypedArray<T, U> so using forward declarations causes conflicts. Stop using forward declarations for typed arrays in union containers. Instead, include headers directly. BUG=671755 Committed: https://crrev.com/26309371fb6eff53769c2fb4bcbe11331b264b82 Cr-Commit-Position: refs/heads/master@{#437717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M third_party/WebKit/Source/bindings/scripts/v8_union.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestInterface2OrUint8Array.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestInterface2OrUint8Array.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
bashi
PTAL BTW, run-bindings-tests seems broken after https://codereview.chromium.org/2554503004/. Presubmit check fails with following errors. ** Presubmit ...
4 years ago (2016-12-09 08:06:54 UTC) #4
Yuki
lgtm
4 years ago (2016-12-09 09:55:16 UTC) #7
haraken
LGTM
4 years ago (2016-12-09 09:56:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559323004/1
4 years ago (2016-12-10 00:15:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-10 01:57:50 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-12 14:59:29 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26309371fb6eff53769c2fb4bcbe11331b264b82
Cr-Commit-Position: refs/heads/master@{#437717}

Powered by Google App Engine
This is Rietveld 408576698