Issue 25593004: Telemetry: Fix printing of number of failed pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25593004: Telemetry: Fix printing of number of failed pages. (Closed)

Created:
7 years, 2 months ago by Dominik Grewe

Modified:
7 years, 2 months ago

Reviewers:
bulach

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Telemetry: Fix printing of number of failed pages. Pass 'telemetry_page_measurement_results' as measurement for both metrics. Distinguish them by passing different values as the trace parameter. This allows us to show both metrics as separate lines in the same graph. BUG=238864 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226484

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -66 lines)			Patch
M	tools/telemetry/telemetry/page/buildbot_page_measurement_results.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/telemetry/telemetry/page/buildbot_page_measurement_results_unittest.py	View	10 chunks	+57 lines, -43 lines	0 comments	Download
M	tools/telemetry/telemetry/page/html_page_measurement_results_unittest.py	View	5 chunks	+21 lines, -21 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominikg@chromium.org/25593004/1

7 years, 2 months ago (2013-10-02 14:33:44 UTC) #3

Message was sent while issue was closed.

Change committed as 226484

Expand Messages | Collapse Messages