tools/telemetry/telemetry/page/html_page_measurement_results_unittest.py - Issue 25593004: Telemetry: Fix printing of number of failed pages.

Unified Diff: tools/telemetry/telemetry/page/html_page_measurement_results_unittest.py

Issue 25593004: Telemetry: Fix printing of number of failed pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/html_page_measurement_results_unittest.py

diff --git a/tools/telemetry/telemetry/page/html_page_measurement_results_unittest.py b/tools/telemetry/telemetry/page/html_page_measurement_results_unittest.py

index 8a838fa18240326b434baa4f6704a2db8c21de82..8bf5b9f813a3f9e6afef035ba21d157b535263cd 100644

--- a/tools/telemetry/telemetry/page/html_page_measurement_results_unittest.py

+++ b/tools/telemetry/telemetry/page/html_page_measurement_results_unittest.py

@@ -70,12 +70,17 @@ class HtmlPageMeasurementResultsTest(unittest.TestCase):

'"units": "seconds", '

'"important": true'

'}, '

+ '"telemetry_page_measurement_results.num_failed": {'

+ '"current": [0], '

+ '"units": "count", '

+ '"important": false'

+ '}, '

'"a_by_url.http://www.bar.com/": {'

'"current": [7], '

'"units": "seconds", '

'"important": false'

'}, '

- '"telemetry_num_failed_pages.": {'

+ '"telemetry_page_measurement_results.num_errored": {'

'"current": [0], '

'"units": "count", '

'"important": false'

@@ -84,11 +89,6 @@ class HtmlPageMeasurementResultsTest(unittest.TestCase):

'"current": [3], '

'"units": "seconds", '

'"important": false'

- '}, '

- '"telemetry_num_errored_pages.": {'

- '"current": [0], '

- '"units": "count", '

- '"important": false'

'}'

@@ -123,24 +123,24 @@ class HtmlPageMeasurementResultsTest(unittest.TestCase):

'"units": "seconds", '

'"important": true'

'}, '

- '"a_by_url.http://www.bar.com/": {'

- '"current": [7], '

- '"units": "seconds", '

+ '"telemetry_page_measurement_results.num_failed": {'

+ '"current": [0], '

+ '"units": "count", '

'"important": false'

'}, '

- '"a_by_url.http://www.foo.com/": {'

- '"current": [3], '

+ '"a_by_url.http://www.bar.com/": {'

+ '"current": [7], '

'"units": "seconds", '

'"important": false'

'}, '

- '"telemetry_num_failed_pages.": {'

+ '"telemetry_page_measurement_results.num_errored": {'

'"current": [0], '

'"units": "count", '

'"important": false'

'}, '

- '"telemetry_num_errored_pages.": {'

- '"current": [0], '

- '"units": "count", '

+ '"a_by_url.http://www.foo.com/": {'

+ '"current": [3], '

+ '"units": "seconds", '

'"important": false'

'}'

@@ -159,12 +159,17 @@ class HtmlPageMeasurementResultsTest(unittest.TestCase):

'"units": "seconds", '

'"important": true'

'}, '

+ '"telemetry_page_measurement_results.num_failed": {'

+ '"current": [0], '

+ '"units": "count", '

+ '"important": false'

+ '}, '

'"a_by_url.http://www.bar.com/": {'

'"current": [8], '

'"units": "seconds", '

'"important": false'

'}, '

- '"telemetry_num_failed_pages.": {'

+ '"telemetry_page_measurement_results.num_errored": {'

'"current": [0], '

'"units": "count", '

'"important": false'

@@ -173,11 +178,6 @@ class HtmlPageMeasurementResultsTest(unittest.TestCase):

'"current": [4], '

'"units": "seconds", '

'"important": false'

- '}, '

- '"telemetry_num_errored_pages.": {'

- '"current": [0], '

- '"units": "count", '

- '"important": false'

'}'

« no previous file with comments | « tools/telemetry/telemetry/page/buildbot_page_measurement_results_unittest.py ('k') | no next file » | no next file with comments »