remove CHANNEL_AUTH_TYPE_SSL from ChannelAuthType

remove CHANNEL_AUTH_TYPE_SSL from ChannelAuthType

Its not being used, except from unit tests.

BUG=644430
Committed: https://crrev.com/d144584589a46a1872f07732d587e6cf60c7a787
Cr-Commit-Position: refs/heads/master@{#438040}

[scf, 2016-12-08 22:34:48]

Description was changed from

==========
remove CHANNEL_AUTH_TYPE_SSL from ChannelAuthType

Its not being used, except from unit tests.

BUG=644430
==========

to

==========
remove CHANNEL_AUTH_TYPE_SSL from ChannelAuthType

Its not being used, except from unit tests.

BUG=644430
==========

[scf, 2016-12-08 22:34:49]

scf@chromium.org changed reviewers:
+ btolsch@chromium.org, mfoltz@chromium.org, wez@chromium.org

[mark a. foltz, 2016-12-08 23:07:34]

mfoltz@chromium.org changed reviewers:
+ vadimgo@chromium.org

[mark a. foltz, 2016-12-08 23:07:34]

Vadim,

This is the patch I was referring to today.  Is it still used by the Cast team
for testing?

[vadimgo, 2016-12-08 23:15:54]

vadimgo@chromium.org changed reviewers:
+ dougsteed@chromium.org, ryanchung@chromium.org

[vadimgo, 2016-12-08 23:17:09]

Added Doug and Ryan to the review - they are more familiar with Cast channel
authentication.

[dougsteed, 2016-12-09 00:42:16]

Not aware of anyone using this for testing, or of any need for the non-verified
case.

[Wez, 2016-12-09 01:46:13]

https://codereview.chromium.org/2559283003/diff/1/extensions/browser/api/cast...
File extensions/browser/api/cast_channel/cast_socket.cc (right):

https://codereview.chromium.org/2559283003/diff/1/extensions/browser/api/cast...
extensions/browser/api/cast_channel/cast_socket.cc:135: DCHECK(channel_auth_ ==
CHANNEL_AUTH_TYPE_SSL_VERIFIED);
No need to DCHECK if that's the only possible value.

https://codereview.chromium.org/2559283003/diff/1/extensions/browser/api/cast...
File extensions/browser/api/cast_channel/logger.cc (right):

https://codereview.chromium.org/2559283003/diff/1/extensions/browser/api/cast...
extensions/browser/api/cast_channel/logger.cc:18: #include
"third_party/zlib/zlib.h"
nit: We should have explicit includes for the cast_channel proto headers here.

https://codereview.chromium.org/2559283003/diff/1/extensions/common/api/cast_...
File extensions/common/api/cast_channel.idl (right):

https://codereview.chromium.org/2559283003/diff/1/extensions/common/api/cast_...
extensions/common/api/cast_channel.idl:55: ssl_verified
If there is only a single ChannelAuthType, do we need the enum at all?

[mark a. foltz, 2016-12-09 04:11:42]

https://codereview.chromium.org/2559283003/diff/1/extensions/common/api/cast_...
File extensions/common/api/cast_channel.idl (right):

https://codereview.chromium.org/2559283003/diff/1/extensions/common/api/cast_...
extensions/common/api/cast_channel.idl:55: ssl_verified
On 2016/12/09 at 01:46:13, Wez wrote:
> If there is only a single ChannelAuthType, do we need the enum at all?

We'll need to deprecate the auth field in ConnectInfo first.  It could be made
optional in this CL to simplify that.

[mark a. foltz, 2016-12-09 04:15:48]

lgtm with wez' comments addressed.

We can update the component extension to not set ConnectInfo.auth, then remove
the field and the enum from the .idl

[scf, 2016-12-09 17:31:38]

Addressing feedback.

[scf, 2016-12-09 17:31:42]

The CQ bit was checked by scf@chromium.org

[scf, 2016-12-09 17:31:43]

The patchset sent to the CQ was uploaded after l-g-t-m from mfoltz@chromium.org
Link to the patchset: https://codereview.chromium.org/2559283003/#ps20001
(title: "Addressing @wez's comments")

[commit-bot: I haz the power, 2016-12-09 17:32:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 18:19:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 18:19:28]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[scf, 2016-12-12 18:15:45]

The CQ bit was checked by scf@chromium.org

[scf, 2016-12-12 18:15:45]

The patchset sent to the CQ was uploaded after l-g-t-m from mfoltz@chromium.org
Link to the patchset: https://codereview.chromium.org/2559283003/#ps40001
(title: "Fixing browser api tests + rebase")

[commit-bot: I haz the power, 2016-12-12 18:16:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scf, 2016-12-12 18:47:57]

scf@chromium.org changed reviewers:
+ lazyboy@chromium.org

[scf, 2016-12-12 18:48:22]

adding @lazyboy as a reviewer for the idl file

[lazyboy, 2016-12-12 18:52:31]

cast_channel.idl RS LGTM.

[scf, 2016-12-12 18:55:29]

The CQ bit was unchecked by scf@chromium.org

[scf, 2016-12-12 18:55:30]

The CQ bit was checked by scf@chromium.org

[commit-bot: I haz the power, 2016-12-12 18:55:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 00:00:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 00:00:45]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[scf, 2016-12-13 00:04:21]

The CQ bit was checked by scf@chromium.org

[commit-bot: I haz the power, 2016-12-13 00:06:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 03:45:59]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481587461462150,
"parent_rev": "29f85177c012fa3b35ef3dacf59279f7e9e1431b", "commit_rev":
"94de0fad189c6dbae43541dc10e470fa84a5f2dc"}

[commit-bot: I haz the power, 2016-12-13 03:46:29]

Description was changed from

==========
remove CHANNEL_AUTH_TYPE_SSL from ChannelAuthType

Its not being used, except from unit tests.

BUG=644430
==========

to

==========
remove CHANNEL_AUTH_TYPE_SSL from ChannelAuthType

Its not being used, except from unit tests.

BUG=644430

Review-Url: https://codereview.chromium.org/2559283003
==========

[commit-bot: I haz the power, 2016-12-13 03:46:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-13 03:49:18]

Description was changed from

==========
remove CHANNEL_AUTH_TYPE_SSL from ChannelAuthType

Its not being used, except from unit tests.

BUG=644430

Review-Url: https://codereview.chromium.org/2559283003
==========

to

==========
remove CHANNEL_AUTH_TYPE_SSL from ChannelAuthType

Its not being used, except from unit tests.

BUG=644430

Committed: https://crrev.com/d144584589a46a1872f07732d587e6cf60c7a787
Cr-Commit-Position: refs/heads/master@{#438040}
==========

[commit-bot: I haz the power, 2016-12-13 03:49:19]

Patchset 3 (id:??) landed as
https://crrev.com/d144584589a46a1872f07732d587e6cf60c7a787
Cr-Commit-Position: refs/heads/master@{#438040}