Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2559123004: update to latest skia api (Closed)

Created:
4 years ago by caryclark
Modified:
4 years ago
Reviewers:
herb_g, dsinclair, reed1
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

update to latest skia api Skia has changed its clipping API from one enum to another. Fix PDFium to match. R=dsinclair@chromium.org,reed@google.com,herb@google.com Review-Url: https://codereview.chromium.org/2559123004 Committed: https://pdfium.googlesource.com/pdfium/+/6814f49aa83916aea14bea2a1e78dac455436713

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/skia/fx_skia_device.cpp View 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
caryclark
4 years ago (2016-12-09 12:54:33 UTC) #3
caryclark
4 years ago (2016-12-09 12:58:49 UTC) #4
reed1
lgtm
4 years ago (2016-12-09 13:11:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559123004/1
4 years ago (2016-12-09 15:21:07 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-09 15:21:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/6814f49aa83916aea14bea2a1e78dac45543...

Powered by Google App Engine
This is Rietveld 408576698