Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 2559123003: Strength-reduce the "scale-factor changed" condition in LayoutSVGRoot (Closed)

Created:
4 years ago by fs
Modified:
4 years ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Strength-reduce the "scale-factor changed" condition in LayoutSVGRoot Spend some cycles examining the difference between the old and new local-to-border-box transforms, and only signal scale-factor changes if that part of the transform changed. This also means that we now detect changes scale that we previously didn't (like [1].) [1] paint/invalidation/svg/absolute-sized-content-with-resources.xhtml BUG=603956, 664961 Committed: https://crrev.com/a229e828a692a3ba58fa5136173f81df1ac8b327 Cr-Commit-Position: refs/heads/master@{#437767}

Patch Set 1 #

Patch Set 2 : Fix overflow invalidation #

Patch Set 3 : Update expectations #

Messages

Total messages: 25 (20 generated)
fs
4 years ago (2016-12-09 20:12:55 UTC) #17
pdr.
LGTM
4 years ago (2016-12-10 06:32:12 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559123003/40001
4 years ago (2016-12-10 09:33:46 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-10 10:36:26 UTC) #23
commit-bot: I haz the power
4 years ago (2016-12-12 15:06:54 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a229e828a692a3ba58fa5136173f81df1ac8b327
Cr-Commit-Position: refs/heads/master@{#437767}

Powered by Google App Engine
This is Rietveld 408576698