Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2559113002: mus/gpu: Introduce the GpuServiceHost mojom interface. (Closed)

Created:
4 years ago by sadrul
Modified:
4 years ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, piman+watch_chromium.org, qsr+mojo_chromium.org, rjkroege, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus/gpu: Introduce the GpuServiceHost mojom interface. GpuServiceInternal uses the new host interface to notify the window server when something happens. The window server does not actually do anything in response yet. BUG=643746, 630895 Committed: https://crrev.com/b92e8e93d160e9b7fa1e8d0dca9a76d17ce71a77 Cr-Commit-Position: refs/heads/master@{#437335}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -59 lines) Patch
M mojo/public/tools/bindings/chromium_bindings_configuration.gni View 1 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/gpu/gpu_main.h View 2 chunks +4 lines, -5 lines 0 comments Download
M services/ui/gpu/gpu_main.cc View 5 chunks +21 lines, -10 lines 0 comments Download
M services/ui/gpu/gpu_service_internal.h View 1 2 4 chunks +3 lines, -1 line 0 comments Download
M services/ui/gpu/gpu_service_internal.cc View 1 2 3 chunks +35 lines, -32 lines 0 comments Download
M services/ui/gpu/interfaces/BUILD.gn View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A services/ui/gpu/interfaces/context_lost_reason.mojom View 1 1 chunk +15 lines, -0 lines 0 comments Download
A services/ui/gpu/interfaces/context_lost_reason.typemap View 1 1 chunk +12 lines, -0 lines 0 comments Download
A services/ui/gpu/interfaces/context_lost_reason_traits.h View 1 2 1 chunk +68 lines, -0 lines 0 comments Download
M services/ui/gpu/interfaces/gpu_main.mojom View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A services/ui/gpu/interfaces/gpu_service_host.mojom View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A services/ui/gpu/interfaces/typemaps.gni View 1 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ws/gpu_service_proxy.h View 1 2 3 chunks +15 lines, -3 lines 0 comments Download
M services/ui/ws/gpu_service_proxy.cc View 1 2 2 chunks +19 lines, -5 lines 0 comments Download

Messages

Total messages: 27 (17 generated)
sadrul
tsepez@ please review mojom, enum-traits. fsamuel@ please review all of it. Thanks!
4 years ago (2016-12-08 17:38:33 UTC) #11
Tom Sepez
lgtm
4 years ago (2016-12-08 17:43:54 UTC) #12
Fady Samuel
lgtm
4 years ago (2016-12-08 18:15:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559113002/60001
4 years ago (2016-12-08 19:00:53 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/321741)
4 years ago (2016-12-08 19:11:38 UTC) #17
sadrul
+rockot@ for mojo/
4 years ago (2016-12-08 19:44:41 UTC) #19
Ken Rockot(use gerrit already)
lgtm
4 years ago (2016-12-08 20:19:48 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559113002/60001
4 years ago (2016-12-08 20:43:43 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-08 21:00:00 UTC) #25
commit-bot: I haz the power
4 years ago (2016-12-08 21:03:25 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b92e8e93d160e9b7fa1e8d0dca9a76d17ce71a77
Cr-Commit-Position: refs/heads/master@{#437335}

Powered by Google App Engine
This is Rietveld 408576698