Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1586)

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc

Issue 255903005: [Sheriff] Disable TaskManagerExistingPrintPreview for being flaky on Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc
diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc b/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc
index 2afff16deedaa15fda42dd458fd848b3c9ae03cc..993854d5c7947161fd8634d36245fd26d224433e 100644
--- a/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc
+++ b/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc
@@ -103,7 +103,14 @@ IN_PROC_BROWSER_TEST_F(PrintPreviewTest, TaskManagerNewPrintPreview) {
ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchPrint("about:blank")));
}
-IN_PROC_BROWSER_TEST_F(PrintPreviewTest, TaskManagerExistingPrintPreview) {
+// Disable the test for mac as it started being flaky, see http://crbug/367665.
+#if defined(OS_MACOSX) && !defined(OS_IOS)
+#define MAYBE_TaskManagerExistingPrintPreview DISABLED_TaskManagerExistingPrintPreview
+#else
+#define MAYBE_TaskManagerExistingPrintPreview TaskManagerExistingPrintPreview
+#endif
+IN_PROC_BROWSER_TEST_F(PrintPreviewTest,
+ MAYBE_TaskManagerExistingPrintPreview) {
// Create the print preview dialog.
Print();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698