Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc

Issue 255903005: [Sheriff] Disable TaskManagerExistingPrintPreview for being flaky on Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/prefs/pref_service.h" 6 #include "base/prefs/pref_service.h"
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "chrome/app/chrome_command_ids.h" 8 #include "chrome/app/chrome_command_ids.h"
9 #include "chrome/browser/content_settings/host_content_settings_map.h" 9 #include "chrome/browser/content_settings/host_content_settings_map.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 96
97 // Create the print preview dialog. 97 // Create the print preview dialog.
98 Print(); 98 Print();
99 99
100 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAboutBlankTab())); 100 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAboutBlankTab()));
101 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAnyTab())); 101 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAnyTab()));
102 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAnyPrint())); 102 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAnyPrint()));
103 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchPrint("about:blank"))); 103 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchPrint("about:blank")));
104 } 104 }
105 105
106 IN_PROC_BROWSER_TEST_F(PrintPreviewTest, TaskManagerExistingPrintPreview) { 106 // Disable the test for mac as it started being flaky, see http://crbug/367665.
107 #if defined(OS_MACOSX) && !defined(OS_IOS)
108 #define MAYBE_TaskManagerExistingPrintPreview DISABLED_TaskManagerExistingPrintP review
109 #else
110 #define MAYBE_TaskManagerExistingPrintPreview TaskManagerExistingPrintPreview
111 #endif
112 IN_PROC_BROWSER_TEST_F(PrintPreviewTest,
113 MAYBE_TaskManagerExistingPrintPreview) {
107 // Create the print preview dialog. 114 // Create the print preview dialog.
108 Print(); 115 Print();
109 116
110 chrome::ShowTaskManager(browser()); // Show task manager AFTER print dialog. 117 chrome::ShowTaskManager(browser()); // Show task manager AFTER print dialog.
111 118
112 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAboutBlankTab())); 119 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAboutBlankTab()));
113 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAnyTab())); 120 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAnyTab()));
114 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAnyPrint())); 121 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAnyPrint()));
115 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchPrint("about:blank"))); 122 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchPrint("about:blank")));
116 } 123 }
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 browser()->tab_strip_model()->ActivateTabAt(0, true); 196 browser()->tab_strip_model()->ActivateTabAt(0, true);
190 197
191 // Navigate main tab to hide print preview. 198 // Navigate main tab to hide print preview.
192 ui_test_utils::NavigateToURL(browser(), GURL("about:blank")); 199 ui_test_utils::NavigateToURL(browser(), GURL("about:blank"));
193 200
194 browser()->tab_strip_model()->ActivateTabAt(1, true); 201 browser()->tab_strip_model()->ActivateTabAt(1, true);
195 } 202 }
196 #endif 203 #endif
197 204
198 } // namespace 205 } // namespace
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698